Thread: compression algorithm outputting wrong data

Hello coders,
The code is supposed to go through the string and every time there are similar characters it's supposed to increment the counter. An input of "303030404040" is supposed to print out "303403" but its printing bogus data!! please help

Code:

#include <iostream>   // std::cout
#include <iomanip>
#include <string>     // std::string, std::to_string
#include <stdlib.h>     /* atof */
#include <math.h>
#include<sstream>
#include <cstring>
#include <vector>
#include <array>
#include <string>
#include <algorithm>

string integerrunlengthencoding(string hextext) {
int counter=1;
    int length = hextext.size(); 
    string output = "";

    for(int i=0;i<length -1;i=i+2){
        for(int k=1;k<length;k=k+2){
            if(hextexts[i] == hextexts[i+2]){
                if(hextexts[k] == hextexts[k+2] ){
                    counter++;
                } else{
                    output = output + hextexts[i] + hextexts[k] + std::to_string(counter);

                    counter =1;                    
                    }            
            }

        }    
    } 
    output = output + hextexts[length -1] + hextexts[length] + 
         std::to_string(counter);
    return output.size() < hextext.size() ? output : hextext; 
}


int main(){
string t = "303030404040";
cout << integerrunlengthencoding(t);
} 

Using two for loops seems wrong to me.

Tim S.

I guess showing you how to debug code was a waste of time then.
comparing characters in a string

Hack-and-post whenever it doesn't work is not a strategy that will work for you long term.
You NEED to figure out how to use tools like debuggers to fix your own mess.