Thread: Linked Lists

Can someone please check and see if im on the right track with this linked list? If i am completely wrong, can you please put me on the right track? :-D

PHP Code:

#include <iostream>
using namespace std;

typedef struct _Node {
    char *name;
    int age;

    struct _Node *next;
} NODE;

NODE *root;

class LinkedList
{
public:
    LinkedList();
    ~LinkedList();

    bool AddNode(char *tName, int tAge);
    bool DelNodeName(char *tName);
    bool DelNodeAge(int tAge);
};

bool LinkedList::AddNode(char *tName, int tAge)
{
    NODE *temp;

    while(temp->next)
    {
        temp = temp->next;
    }

    NODE *NewNode;
    NewNode = new NODE;
    NewNode = temp->next;
    temp->next = NewNode;
    NewNode->name = tName;
    NewNode->age = tAge;

    return true;
}

bool LinkedList::DelNodeAge(int tAge)
{
    NODE *temp;

    temp = root;

    while(temp->next->age != tAge)
    {
        temp = temp->next;
    }
    temp->next = temp->next->next;

    delete temp->next;

    return true;
}

int main(int argc, char *argv[])
{
    return 0;
} 


> NODE *root;
This should be a class member

> bool LinkedList::AddNode(char *tName, int tAge)
{
NODE *temp;
temp is uninitialised
And I see no point in always returning true

PHP Tags do not make for good source code posting
>
bool LinkedList:<img src="images/smilies/biggrin.gif" border="0" alt="">elNodeAge
(whatever that is)
You need to be especially carefull when
- there is only one node in the list
- when the node being deleted is at the head/tail of the list

The usual loop for linked lists is

Code:

    NODE *temp = root;
    while ( temp != NULL ) {
        // do stuff with node
        temp = temp->next;
    }

Which easily copes with empty lists, lists with one element etc

I don't understand why you are using a C style struct in the same program as a C++ type class. Use a C++ type struct instead. Or, if you prefer, create a class to implement the node instead, since the only difference between a struct and a class in C++ is what default access the members have.