Thread: Simple program: no output.

Hi all,

I was wondering if someone here could help me. I don't understand why 'phrase_1' doesn't print. I hope you can see that this program's intentions are to reverse whats stored in the string 'phrase' and store the result in 'phrase_1'.

Thank in advance:

Code:

#include <iostream>
#include <string>
#include <stdio.h>
using namespace std;


int main()
{
    char phrase[11];
    char phrase_1[11] = "";


    cin.getline(phrase, 11, '\n');
    cout << "The phrase you entered was: " << phrase << endl;


    for (int i = 0; i <= strlen(phrase); ++i)
    {
        phrase_1[i] = phrase[strlen(phrase) - 1- i];
    }
    
    cout << "Phrase_1 is: " << phrase_1 << endl;


    return 0;


}

You aren't properly zero-terminating the C-style string.

Code:

#include <iostream>
#include <cstring>
using namespace std;

int main() {
    char phrase[100], phrase2[100];

    cin.getline(phrase, sizeof phrase);
    cout << "The phrase you entered was: " << phrase << '\n';

    size_t len = strlen(phrase);
    for (size_t i = 0; i < len; ++i)
        phrase2[i] = phrase[len - 1 - i];

    phrase2[len] = '\0';  // zero-terminate the string

    cout << "Phrase2 is: " << phrase2 << '\n';
 
    return 0;
}

Of course, if you really want to write a C++ program then you should use C++ strings.

Code:

#include <iostream>
#include <string>
using namespace std;

int main() {
    string phrase, phrase2;

    getline(cin, phrase);
    cout << "The phrase you entered was: " << phrase << '\n';

    for (size_t i = 0; i < phrase.size(); ++i)
        phrase2 += phrase[phrase.size() - 1 - i];

    cout << "Phrase2 is: " << phrase2 << '\n';
 
    return 0;
}