Thread: Program prints garbage

Code:

#include <iostream>
using namespace std;
#include <string>
class IceCreamCone
{
    private:
        string flavor;
        int numOfScoops;
        string typeOfCone;
        float price;
    public:
        IceCreamCone(string = "Vanilla",  int = 1 , string = "Sugar");
        void setPrice();
        float getPrice();
};
void IceCreamCone::setPrice()
{
    price = 0;
}
float IceCreamCone::getPrice()
{
    return price;
}
IceCreamCone::IceCreamCone(string flvr, int numScoops , string typeCone )
{
    setPrice();
    price = 0.75 * (float)numOfScoops;
    if( typeCone == "waffle")
        price += 0.40;


}
int main(void)
{
    IceCreamCone iceCream;
    IceCreamCone iceCreamTwo("chocolate", 3 , "waffle" );
    
    cout << iceCream.getPrice() << endl;
    cout << iceCreamTwo.getPrice() << endl; // prints "garbage"
    
    return 0;
}

In the main function after calling function getPrice() (line 39) for the object iceCreamTwo it ends up printing garbage,

Code:

cout << iceCreamTwo.getPrice() << endl;

and I am not quite sure why it happens, since program prints good number for iceCream object.

Actually both of your output lines are printing garbage, just different garbage.

You need to check to insure that your member variables are properly initialized in your constructor. By the way I don't recommend using default values for constructor parameters.

Jim

Originally Posted by jimblumberg

Actually both of your output lines are printing garbage, just different garbage.

You need to check to insure that your member variables are properly initialized in your constructor. By the way I don't recommend using default values for constructor parameters.

Jim

I don't see how member variables in the constructor are improperly initialized , could you just give me some hint , I have just started to learn about C++.

I don't see how member variables in the constructor are improperly initialized

Show me where you think you have initialized all of the member variables in your class.

Code:

    private:
        string flavor;
        int numOfScoops;
        string typeOfCone;
        float price;
...
IceCreamCone::IceCreamCone(string flvr, int numScoops , string typeCone )
{
    setPrice();
    price = 0.75 * (float)numOfScoops;
    if( typeCone == "waffle")
        price += 0.40;
 
 
}

Jim

Originally Posted by jimblumberg

Show me where you think you have initialized all of the member variables in your class.

Code:

    private:
        string flavor;
        int numOfScoops;
        string typeOfCone;
        float price;
...
IceCreamCone::IceCreamCone(string flvr, int numScoops , string typeCone )
{
    setPrice();
    price = 0.75 * (float)numOfScoops;
    if( typeCone == "waffle")
        price += 0.40;
 
 
}

Jim

Sorry, I didn't initialize all of the member variables ( I kinda mix terms initialization and assignment , since I am not native english speaker) and , I am kinda confused right now , please could you tell me why would I need to initialize all the member variables.

Because if you don't initialize (assign) values to your variables they have undefined values (garbage).

I kinda mix terms initialization and assignment

The only real difference between initialization and assignment is that initialization happens once, when you define the variable. After the variable is defined you assign values to the variable.

Code:

// Definition, no initialization.
int n; 

// Definition with initialization.
int m = 10;
int i = m;

// Assignment.
n = 100;
m = n;

In your constructor the only variable you initialized was price (to zero). All the other variables have undefined values.

Jim