New to C++ and need assistance

[James P. Smith]

Hello, I am new to C++ and I am enjoying it very much when I am getting it! I wrote a program to generate random numbers like a lottery but i have a few quirks in it, hopefully someone can assist me in correcting. I have extensively searched to find an answer and cannot. been working on this for about two days.
1. I don't understand why i need to add a star next to my for loop to insure the input number is under 10.
2. That same loop only works for the first input not any others.
3. My random number generator is producing 0,0,0,0,1493466176 every time. (or similar last number).
when I run this on my downloaded compiler it does what is stated above, if i run this on ideoneit.com it just runs all lines (ie. tells me i need to enter a number between 0 and 9, 5 times, but doesn't allow me to enter) and spits out 5 very large numbers.

/* James Smith
week5 assignment 1
lottery generator*/
#include <iostream>
#include <cstdlib>
#include <ctime>
using namespace std;
//function prototype
double randomnum(int);
int main ()
{
//declare variables
int lottery[5], user[5];
//introduce program
cout << "Is today your lucky day?? Play the lottery and find out! \n" << endl;
//get user numbers
cout << "Please input your 5 lucky numbers between 0 and 9! \n";
for (int i=0; i<5; i++)
{
 cout <<"Lucky number"<< (i+1)<<": ";
cin >> user[i];
if (*user>10)// why is this making me add a star? also only works for the first input
{
    cout <<"The number must be between 0 and 9, please reenter" << endl;
    cin >> user[i];
}
}
//generate lottery numbers
randomnum;
//display lottery numbers
for(int i=0; i<5; i++)
{
cout << lottery[i] <<" " << endl;
}
//declare if a winner or not
for (int n=0; n<1; n++)
{
    if (user[n] == lottery [n])
    cout << "You were right it was your lucky day!! Congratulation you matched all 5 numbers!!" << endl;
    else
    cout << "I'm sorry you did not match all 5 numbers please play again" << endl;
    }
return 0;
}
double randomnum(int lottery)
{
        int num[5];
        for (int i =0; i<5; i++)
        {
            //initialize random seed
            srand (time(0));
            // generate number
            return num[i] =rand()%9;//getting garbage numbers
        }
}

[James P. Smith]

i just made a few changes trying to look into this for my function prototype, I don't know if it matters to you, but it didn't change anything.
line 45 double random(int lottery[]);
line 29 randomness(lottery);
line 9 double random (int[]);

[Yarin]

It's a good thing you wrote it all flat. Indentation just gets in the way. Keep up the good work.

[Elysia]

To be less cryptic, you need to indent your code properly and let the board handle the formatting. Copy and paste into notepad or some similar application that strips color coding before pasting it into the reply box.

[jiggunjer]

Regarding 1: remember user is the name of an array. So comparing an entire array with an int 10 doesn't work. The name of an array acts like a pointer to the first element. So *user is just another way of saying user[1].

[MutantJohn]

It's a good thing you wrote it all flat. Indentation just gets in the way. Keep up the good work.

This made me actually laugh out loud.

But I'm scared the OP won't get that it's sarcasm.

OP, Yarin was being sarcastic. Indentation and whitespace really, really help make code readable.

[whiteflags]

if (*user>10)// why is this making me add a star? also only works for the first input

It's not making you do that, per se. Using the dereference operator is the minimum amount of effort required to read a value from user, given that user is an array.

In most contexts an array name will decay to a pointer to the first element (i.e. apart from the sizeof operator, & operator, and when the array in question is a string literal).

So, typing *user is virtually the same as user[0]. The second form usually has the advantage of being more readable and it's easy to pick another part of the array, for ex. user[i]. Just like how you did for the rest of the program.

[Elysia]

Regarding 1: remember user is the name of an array. So comparing an entire array with an int 10 doesn't work. The name of an array acts like a pointer to the first element. So *user is just another way of saying user[1].

Correction: user[0].

[jiggunjer]

Doh, yea user[0]. I also recommend this post to read more on the matter: Are pointers and arrays equivalent in C? - Eli Bendersky's website