Thread: Writing program that prints out each digit of an entered number, loop question

I'm writing a program that prints out each digit of an entered (integer) number, and stores each digit in an array. I have two functions, main and another function that does the calculations itself. The program needs to cut off ( / 10) each digit in the number and save it seperately so it can all be printed at the end, but to do that it needs to know how many digits (actual filled out digits, not just index...... I think) are in the array, which I assume requires a loop that cuts off every digit and makes another counting variable go up- but what would be the condition, since to do that the correct number of times you would need to know how many digits are in the array!
My current code is:

Code:

#include <iostream>
#include <iomanip>
#include <cmath>
using namespace std;


int explode(int number, int array[])
{
    int store = 0;
    for(int i = 0; i < array[10]; i++) {
            cin >> array[i];
            store = array[i];
            }
    
}


int main()
{
	int digits[10];
	int numdigits;
	
	int n;
	cout << "Enter number: ";
	cin >> n;
	
	numdigits = explode(n,digits);
	
	cout << "[" << digits[0];
	for( int i = 1; i < numdigits; i++ )
		cout << "," << digits[i];
	cout << "]" << endl;
}

If I am understanding anything wrong please tell me, I don't have a good understanding of the problem in the first place. Also I know my main function is correct, there are no problems with it. It's something in my understanding of the problem.

You should google your problems more.

c - Getting each individual digit from a whole integer - Stack Overflow

Code:

int score = 123456789;

while(score)
{
    printf("%d\n", score % 10);
    score /= 10;
}

Without the printf, what variable would be the variable printed? Score I assume?

Originally Posted by Kelton2

Without the printf, what variable would be the variable printed? Score I assume?

Each digit of score.

You should only call std::cin once this whole program, just to get the initial integer.

You should then be able to use this while-loop to "explode" that integer and store each digit in an array. How you choose to store things is up to you but this while loop will give you the extracted digits.

Note that this while-loop will give you digits starting from the right so the first number output from the code I posted would be 9 and the last number output will be 1.

Doesn't work:

Code:

#include <iostream>
#include <iomanip>
#include <cmath>
using namespace std;


int explode(int number, int array[])
{
    int score = 123456789;
 
while(score)
{
   // printf("%d\n", score % 10);
    score /= 10;
}
return score;
}


int main()
{
	int digits[10];
	int numdigits;
	
	int n;
	cout << "Enter number: ";
	cin >> n;
	
	numdigits = explode(n,digits);
	
	cout << "[" << digits[0];
	for( int i = 1; i < numdigits; i++ )
		cout << "," << digits[i];
	cout << "]" << endl;
}

It doesn't work because you don't know what the code I posted does.

That's funny because this works perfectly for me :

Code:

#include <iostream>
#include <cassert>


void extract
(
const int n,
const int capacity,
int *digits,
int &num_digits
)
{
    int cpy = n;


    while (cpy)
    {
        assert(num_digits < capacity && "Too many digits!");


        const int digit = cpy % 10;
        cpy /= 10;


        digits[num_digits] = digit;


        ++num_digits;
    }
}


int main(void)
{
    int data[64] = { 0 };


    const int n = 123456789;


    int num_digits = 0;


    extract(n, 64, data, num_digits);


    for (int i = 0; i < num_digits; ++i)
        std::cout << data[i] << std::endl;


    return 0;
}

And for the future, saying, "doesn't work" isn't exactly productive.

Originally Posted by MutantJohn

It doesn't work because you don't know what the code I posted does.

That's funny because this works perfectly for me :

Code:

#include <iostream>
#include <cassert>


void extract
(
const int n,
const int capacity,
int *digits,
int &num_digits
)
{
    int cpy = n;


    while (cpy)
    {
        assert(num_digits < capacity && "Too many digits!");


        const int digit = cpy % 10;
        cpy /= 10;


        digits[num_digits] = digit;


        ++num_digits;
    }
}


int main(void)
{
    int data[64] = { 0 };


    const int n = 123456789;


    int num_digits = 0;


    extract(n, 64, data, num_digits);


    for (int i = 0; i < num_digits; ++i)
        std::cout << data[i] << std::endl;


    return 0;
}

And for the future, saying, "doesn't work" isn't exactly productive.

Is there a way to do it without cassert? I don't like using header files I don't know how to use.

You don't know what assert() is?

So... You don't know what modulo is and now you don't know what assert() is... Homie-manger, you gotta start doing some reading.

Here's a modulus explanation : Math Forum - Ask Dr. Math

And as for assert, assert - cppreference.com

Google is your friend, man.

Now, if you're curious about how I used it the way that I did, I'd be happy to tell you but you need to first off, read Alpo's post and understand it then read up on what the modulo operator does and what assert() does. These are pretty basic things that you need​ to know.

Thanks, but it only almost works. It prints the numbers backwards, and with an extra , that IDK how to easily get rid of.
Code:

Code:

#include <iostream>
#include <cassert>
using namespace std; 
void extract
(
const int n,
const int capacity,
int *digits,
int &num_digits
)
{
    int cpy = n;
 
 
    while (cpy)
    {
        assert(num_digits < capacity && "Too many digits!");
 
 
        const int digit = cpy % 10;
        cpy /= 10;
 
 
        digits[num_digits] = digit;
 
 
        ++num_digits;
    }
}
 
 
int main()
{
    int data[64] = { 0 };
    int n2;
    cin >> n2;
    const int n = n2;
    int num_digits = 0;
    extract(n, 64, data, num_digits);
    cout << "[";
    for (int i = 0; i < num_digits; ++i) {
        cout << data[i] << ",";
}
cout << "]";
 
    return 0;
}

It doesn't print the numbers backwards.

I told you in my earlier posts that it reads right to left so 9 is the first digit.

This makes sense as 123456789 is really the sum of 9 * 10^0 + 8 * 10^1 + 7 * 10^2 + ...

The array is stored such that the index of the element is also the proper power. This is why 9 is at 0, 8 is at 1, 7 is at 2, etc.

This means you need to print your array in reverse so you start at num_digits - 1 and go all the way to 0.

Originally Posted by MutantJohn

It doesn't print the numbers backwards.

I told you in my earlier posts that it reads right to left so 9 is the first digit.

This makes sense as 123456789 is really the sum of 9 * 10^0 + 8 * 10^1 + 7 * 10^2 + ...

The array is stored such that the index of the element is also the proper power. This is why 9 is at 0, 8 is at 1, 7 is at 2, etc.

This means you need to print your array in reverse so you start at num_digits - 1 and go all the way to 0.

I'm still confused? What array/variable do I need to change to what to make it print right?

Originally Posted by Kelton2

I'm still confused? What array/variable do I need to change to what to make it print right?

I've basically already done your homework for you. Surely, you can figure this out on your own. If you don't know what array is storing the digits in the code I posted, I don't know what to tell you other than, re-read the code but this time, for understanding.