Thread: Need help writing......

Originally Posted by Kelton2

Code:

   if(value != highest || value != lowest) {
    average /= 5;
}

Oh dear. You should ask your school for a refund.

Originally Posted by Kelton2

And what is good indentation?

C Indentation

OK, now I have

Code:

#include <iostream>
#include <iomanip>
using namespace std;
int main( ) {
float n;
float average = 0;
float o;
float value = 0;
float highest = 0;
float lowest = 0;
    
//  cin >> o;
n = 7;
for (float i = 0; i < n; ++i) {
    highest = value;
    lowest = value;
    cin >> value;
    if (value > highest) {
        highest = value;
    }
    if (value < lowest) {
        lowest = value;
    }
 
    average += value;
 
}
    if (value != highest || value != lowest) {
    average /= 5;
}
// average = average + 1;
cout << "Average score: " << setprecision(3) << average;
}

So how do I fix it? I followed some of the previous posts, but it still is not giving me the correct result.

I suggest you add a simple print statement that prints the highest and lowest between line 31 and 33. Then reread post #15, pay particular attention to the first question: "Why do you do this everytime?"

I followed some of the previous posts,

Why just "some"?

Jim

It correctly shows 9.1 as the highest, but incorrectly shows 8 as the lowest.
As for why do you do this everytime, I thought that was the way to record the highest and lowest. If I am wrong please explain why and help me get it right.

Originally Posted by Kelton2

As for why do you do this everytime, I thought that was the way to record the highest and lowest. If I am wrong please explain why and help me get it right.

You record the highest and lowest alright, but overwrite them just afterwards with value.

You mean in

Code:

highest = value;

and

Code:

lowest = value;

?
If so, how else am I supposed to do it? My logic there is if a new highest is found, highest becomes that highest, and same for lowest. I must be doing it wrong somehow though.

The simplest way to do it would be to initialize these variables with INT_MIN and INT_MAX respectively.
(highest with INT_MIN , not the other way around)
You can find these macros in <limits.h>

Sorry, I can't use any other header files in my situation.

Originally Posted by manasij7479

The simplest way to do it would be to initialize these variables with INT_MIN and INT_MAX respectively.
(highest with INT_MIN , not the other way around)
You can find these macros in <limits.h>

Only, he's using floats, not ints.

The best approach is to set the highest and lowest to the first value given, and compare from thereon.

Originally Posted by Yarin

Only, he's using floats, not ints.

The best approach is to set the highest and lowest to the first value given, and compare from thereon.

But that's what I'm doing, and it's not working.

Originally Posted by Kelton2

But that's what I'm doing, and it's not working.

-_-
Do you know what for does?

Originally Posted by Yarin

Only, he's using floats, not ints.

Oops..missed that.

The best approach is to set the highest and lowest to the first value given, and compare from thereon.

Yes, but implementing that takes a little bit more wizardry!

So does the first value have to be given outside the loop?

Originally Posted by Kelton2

So does the first value have to be given outside the loop?

Yes.
Take the value input once outside the loop.
Assign that value to both highest and lowest.
And then run the loop n-1 times instead of n times.