Change making program prints correct values but prints them over and over.

[Kelton2]

I have a program that makes change from an amount. It works fine, but the output is the correct output looped over and over. I have tried everything, but it still doesn't work. For example, a amount of 98 should print
3 quarters
2 dimes
0 nickles
3 pennies
but instead it prints
3 quarters
2 dimes
0 nickels
3 pennies
0 quarters
2 dimes
0 nickels
3 pennies
0 quarters
2 dimes
0 nickels
3 pennies
Can someone figure out why it's doing this?

#include <iostream>
using namespace std;
int coinscount(int& amount, int value) {
    int tracker = 0;
    int amountdimes = amount;
    int trackdimes = 0;
    int amountnickles = amount;
    int tracknickles = 0;
    int amountpennies = amount;
        for(amount; amount > 24; amount-= 25) {
                    tracker++;
        }
        cout << tracker << " quarters";
                     cout << endl;
        for(amountdimes= amount % 25 ; amountdimes > 9; amountdimes-= 10) {
                     trackdimes++;
                     }
                     
                     cout << trackdimes << " dimes";
                     for(amountnickles = amountdimes % 10; amountnickles > 4; amountnickles-= 5) {
                                  tracknickles++;
                                  }
                                  
                                  
                                  amountpennies = amountnickles % 5;
        cout << endl;
        cout << tracknickles << " nickels";
        cout << endl;
        cout << amountpennies << " pennies";
        cout << endl;
        }
int main ( ) {
    int amountmain;
    cout << "Enter an amount: ";
    cin >> amountmain;
    cout << endl;
   
    coinscount(amountmain, amountmain); 
  
  coinscount(amountmain, amountmain); 


  coinscount(amountmain, amountmain); 
  
}

Any help would be very appreciated.

[Kelton2]

Any help?

[laserlight]

For starters, you need to format your code properly, especially where indentation is concerned. For example:

#include <iostream>

using namespace std;

int coinscount(int& amount, int value) {
    int tracker = 0;
    int amountdimes = amount;
    int trackdimes = 0;
    int amountnickles = amount;
    int tracknickles = 0;
    int amountpennies = amount;
    for (amount; amount > 24; amount-= 25) {
        tracker++;
    }
    cout << tracker << " quarters";
    cout << endl;
    for (amountdimes = amount % 25; amountdimes > 9; amountdimes -= 10) {
        trackdimes++;
    }

    cout << trackdimes << " dimes";
    for (amountnickles = amountdimes % 10; amountnickles > 4; amountnickles-= 5) {
        tracknickles++;
    }

    amountpennies = amountnickles % 5;
    cout << endl;
    cout << tracknickles << " nickels";
    cout << endl;
    cout << amountpennies << " pennies";
    cout << endl;
}

int main() {
    int amountmain;
    cout << "Enter an amount: ";
    cin >> amountmain;
    cout << endl;

    coinscount(amountmain, amountmain);

    coinscount(amountmain, amountmain);

    coinscount(amountmain, amountmain);
}

Your problem appears to be the direct result of calling coinscount three times instead of just once.

EDIT:
Oh wait, Kelton2, this issue about code formatting isn't for starters anymore. You have been told over and over and over again. I have provided you example after example. If you have problems understanding what good formatting looks like, or what are the reasonably accepted practices for indentation, please voice it out now.

[Aslaville]

Oh wait, Kelton2, this issue about code formatting isn't for starters anymore. You have been told over and over and over again. I have provided you example after example. If you have problems understanding what good formatting looks like, or what are the reasonably accepted practices for indentation, please voice it out now.

On the other paw, if you are *toooo* lazy to do the formatting, you could just throw it at 'clang-format' and edit a few things thereafter