Thread: Problem with reading a file into array of struct

Code:

#include <iostream>
#include <fstream>
#include <iomanip>
using namespace std;

struct inventory
{
    int barcode;
    char description[512];
    float price;
    int quantity;
};


int main()
{
    cout << fixed;
    cout << setprecision(2);

    inventory s[4];

    char filename[128];
    ifstream infile;
    cout <<"Enter the file name : ";
    cin.getline(filename, 128);
    infile.open(filename);

        while (!infile)
        {
        cout << "File could not be opened"<<endl;
        cout <<"Enter the file name again :";
        cin.getline(filename, 128);
        infile.open(filename);
        }



        while (!infile.eof())
        {
            if (!infile.eof())
            {
            for(int i = 0; i < 4; i++)
            {
            infile >> s[i].barcode;
            cin.ignore();
            infile.getline(s[i].description, 512);
            infile >> s[i].price;
            infile >> s[i].quantity;
            }
            }
        }



        for(int i = 0; i < 4; i++)
        {
        cout << "barcode : " << s[i].barcode << endl;
        cout << "description : " << s[i].description << endl;
        cout << "price : " << s[i].price << endl;
        cout << "quantity : " << s[i].quantity << endl;
        cout << endl;
        }



        return 0; 
}

This is my text file

20123451 Sugar packet (1 kg) 2.50 560 21347652 Milo 3-in-1 12.50 200 20123453 Salt (1kg) 4.50 270 21347654 Nescafe 3-in-1 12.50 400 20123455 Tamatoes 4.00 100 21347656 Cucumbers 4.00 280

This is my program output

Enter the file name : "filename".txt ..... (Nothing shows up)

Any help would be greatly appreciated.

The problem is that your loop might never end: EOF is detected when an attempted read fails, but you are only reading 4 times. Furthermore, you did not consider what happens if there are fewer than 4 entries. I suggest something like this:

Code:

int inventory_count = 0;
while (inventory_count < 4)
{
    if (infile >> s[inventory_count].barcode &&
        infile.ignore() &&
        infile.getline(s[inventory_count].description, 512) &&
        infile >> s[inventory_count].price >> s[inventory_count].quantity)
    {
        ++inventory_count;
    }
    else
    {
        break;
    }
}

for (int i = 0; i < inventory_count; ++i)
{
    cout << "barcode : " << s[i].barcode << endl;
    cout << "description : " << s[i].description << endl;
    cout << "price : " << s[i].price << endl;
    cout << "quantity : " << s[i].quantity << endl;
    cout << endl;
}

This way, you test the return value of the reading functions instead of testing with eof(). You keep track of the number of entries read without assuming that there will be exactly 4 of them (but using the loop condition to limit them to a maximum of 4). Finally, you print based on the number of entries read, again without assuming that there are exactly 4 entries to print.

I have taken the liberty of changing your cin.ignore() to infile.ignore().

I suggest you use std::string instead of char arrays.
Using the >> operator with char arrays is not safe.