Thread: One-Dimensional Array

Can anybody help me with my program? I can't get the example. Here's the question: Create a program that accepts an array of characters. And displays the converted array of characters into Upper case if it is given in
Lowercase and vice versa. Don't use string, but char.

Example: mychar ="I am A conQUeror."

Code:

//My Codes:
#include <iostream>
#include <conio.h>
using namespace std;
int main() 
{
cout << "Password? \n";
char input[256];
cin.get(input, 256);
for(int i = 0; i < strlen(input); i++)
{
        input[i] = toupper(input[i]);
        cout << endl << input << endl;
        }
for(int i = 0; i < strlen(input); i++)
{
        input[i] = tolower(input[i]);
        cout << endl << input << endl;
        }
getch ();
return 0;
}

You currently run 2 loops through your input, 1 which uppercases everything, then another which lowercases everything...so the end result is just going to be everything lowercased, you are also outputting the string way too often for some reason? You should only output the string once after you have modified it in the way I describe below.

What you really need to do is simply go through the string and check if the letter is uppercase. If the letter is uppercase, lowercase it. If the letter is not uppercase, uppercase it.
You should use the header files: <cctype> and <cstring> to get the toupper, tolower, isupper() and strlen() functions properly.

That was such an advise, after reading it I innovated all my codes specially the looping portion but the sad effect was that the output hasn't met what I am looking for. Any more help dude?

Code:

#include <iostream>
#include <conio.h>
#include <cctype>
#include <cstring>
using namespace std;
int main ()
{
cout << "Password? \n";
char input[256];
cin.get(input, 256);
for (int i = 0; input[i] != '\0'; i++)
{
    if (isupper(input[i]))
    {
        input[i] = tolower(input[i]);
    }
    else if (islower(input[i]))
    {
        input[i] = toupper(input[i]);
        }


cout << input << '\n';
getch ();
return 0;
}
}

Good job you got it pretty much right. The only problem is that your cout << input << '\n'; and getch() call are still INSIDE your for() loop. You want to print the data AFTER you have modified it right? So you need to print it after the for loop is done.

You could also simplify the if/else if case a bit more. If you know isupper() is FALSE then do you really need to test islower() also?

Got it! Putted the getch and the return outside, I forgot putting it outside. Thanks.