Compile a source on freebsd( Gmake , Gcc48 ) Some warnings

[RebootS]

Hey guys ... I'm new here so please be indulgent.

char.cpp: In member function 'void CHARACTER::PointChange(BYTE, int, bool, bool)':char.cpp:3088: warning: comparison between signed and unsigned integer expressions
In file included from char_item.cpp:47:
belt_inventory_helper.h: In static member function 'static BYTE CBeltInventoryHelper::GetBeltGradeByRefineLevel(int)':
belt_inventory_helper.h:28: warning: comparison between signed and unsigned integer expressions
char_item.cpp: In member function 'bool CHARACTER::IsEmptyItemGrid(TItemPos, BYTE, int) const':
char_item.cpp:640: warning: comparison is always false due to limited range of data type
char_item.cpp:666: warning: comparison is always false due to limited range of data type
char_item.cpp: In member function 'bool CHARACTER::UseItemEx(CItem*, TItemPos)':
char_item.cpp:2389: warning: format '%d' expects type 'int', but argument 6 has type 'long int'
char_item.cpp:2393: warning: format '%d' expects type 'int', but argument 6 has type 'long int'
char_item.cpp:2405: warning: format '%d' expects type 'int', but argument 5 has type 'long int'
char_item.cpp:2409: warning: format '%d' expects type 'int', but argument 5 has type 'long int'
char_item.cpp:2436: warning: format '%d' expects type 'int', but argument 6 has type 'long int'
char_item.cpp:2444: warning: format '%d' expects type 'int', but argument 5 has type 'long int'
char_item.cpp:5577: warning: comparison between signed and unsigned integer expressions
char_item.cpp: In member function 'bool CHARACTER::UseItem(TItemPos, TItemPos)':
char_item.cpp:5649: warning: unused variable 'wDestCell'
char_item.cpp:5650: warning: unused variable 'bDestInven'
char_item.cpp: In member function 'bool CHARACTER::EquipItem(CItem*, int)':
char_item.cpp:6655: warning: array subscript has type 'char'
char_item.cpp: In member function 'void CHARACTER::BuffOnAttr_AddBuffsFromItem(CItem*)':
char_item.cpp:6719: warning: comparison between signed and unsigned integer expressions
char_item.cpp: In member function 'void CHARACTER::BuffOnAttr_RemoveBuffsFromItem(CItem*)':
char_item.cpp:6731: warning: comparison between signed and unsigned integer expressions
char_item.cpp: In member function 'bool CHARACTER::CanEquipNow(CItem*, const TItemPos&, const TItemPos&)':
char_item.cpp:7917: warning: unused variable 'itemType'
char_item.cpp:7918: warning: unused variable 'itemSubType'
char_item.cpp: In member function 'bool CHARACTER::IsEmptyItemGrid(TItemPos, BYTE, int) const':
char_item.cpp:679: warning: control reaches end of non-void function
char_state.cpp: In member function 'virtual void CHARACTER::StateMove()':
char_state.cpp:901: warning: unused variable 'rider'
PetSystem.cpp: In member function 'virtual bool CPetActor::_UpdateFollowAI()':
PetSystem.cpp:239: warning: unused variable 'bDoMoveAlone'
PetSystem.cpp: In member function 'CPetActor* CPetSystem::Summon(DWORD, CItem*, const char*, bool, DWORD)':
PetSystem.cpp:545: warning: unused variable 'petVID'
cube.cpp: In function 'bool Cube_make(CHARACTER*)':
cube.cpp:544: warning: comparison between signed and unsigned integer expressions
cube.cpp: In function 'void Cube_MakeCubeInformationText()':
cube.cpp:716: warning: unused variable 'npcVNUM'
cube.cpp: In function 'bool Cube_InformationInitialize()':
cube.cpp:783: warning: comparison between signed and unsigned integer expressions
In file included from config.cpp:22:
check_server.h: In static member function 'static bool CheckServer::CheckIp(const char*)':
check_server.h:24: warning: comparison between signed and unsigned integer expressions
config.cpp: In function 'void config_init(const std::string&)':
config.cpp:504: warning: unused variable 'line'
char_item.cpp: In member function 'void CHARACTER::BuffOnAttr_ValueChange(BYTE, BYTE, BYTE)':
char_item.cpp:6766: warning: 'pBuff' may be used uninitialized in this function
cmd_gm.cpp: In function 'void do_set_stat(CHARACTER*, const char*, int, int)':
cmd_gm.cpp:4071: warning: NULL used in arithmetic
desc_client.cpp: In member function 'void CLIENT_DESC::UpdateChannelStatus(DWORD, bool)':
desc_client.cpp:299: warning: comparison between signed and unsigned integer expressions
cmd_gm.cpp:4113: warning: 'n' may be used uninitialized in this function
cmd_gm.cpp: In function 'void do_use_item(CHARACTER*, const char*, int, int)':
cmd_gm.cpp:4493: warning: 'cell' may be used uninitialized in this function
cmd_gm.cpp: In function 'void do_mob_ld(CHARACTER*, const char*, int, int)':
cmd_gm.cpp:855: warning: 'x' may be used uninitialized in this function
cmd_gm.cpp:855: warning: 'y' may be used uninitialized in this function
input_auth.cpp: In member function 'int CInputAuth::auth_OpenID(const char*, const char*, char*)':
input_auth.cpp:436: warning: unused variable 'last'
input_main.cpp: In member function 'int CInputMain::Chat(CHARACTER*, const char*, size_t)':
input_main.cpp:788: warning: unused variable 'len_global'
input_main.cpp: In member function 'void CInputMain::Move(CHARACTER*, const char*)':
input_main.cpp:1593: warning: unused variable 'fDist'
In file included from item.cpp:22:
belt_inventory_helper.h: In static member function 'static BYTE CBeltInventoryHelper::GetBeltGradeByRefineLevel(int)':
belt_inventory_helper.h:28: warning: comparison between signed and unsigned integer expressions
item.h: In constructor 'CItem::CItem(DWORD)':
item.h:286: warning: 'CItem::m_pkRealTimeExpireEvent' will be initialized after
item.h:283: warning:   'LPEVENT CItem::m_pkExpireEvent'
item.cpp:25: warning:   when initialized here
item.cpp: In function 'const bool CanPutIntoRing(CItem*, CItem*)':
item.cpp:1728: warning: unused variable 'vnum'
item.cpp: In member function 'bool CItem::CanPutInto(CItem*)':
item.cpp:1761: warning: comparison between signed and unsigned integer expressions
item.cpp: In member function 'int CItem::GiveMoreTime_Per(float)':
item.cpp:2017: warning: comparison between signed and unsigned integer expressions
item.cpp:2019: warning: comparison between signed and unsigned integer expressions
item.cpp: In member function 'int CItem::GiveMoreTime_Fix(DWORD)':
item.cpp:2041: warning: comparison between signed and unsigned integer expressions
item.cpp: In member function 'int CItem::GetDuration()':
item.cpp:2072: warning: array subscript has type 'char'
item_manager.cpp: In member function 'TItemTable* ITEM_MANAGER::GetTable(DWORD)':
item_manager.cpp:604: warning: comparison between signed and unsigned integer expressions
questlua.cpp: In member function 'bool quest::FPartyCheckFlagLt::operator()(CHARACTER*)':
questlua.cpp:78: warning: 'returnBool' may be used uninitialized in this function
questlua_npc.cpp: In function 'int quest::npc_get_vid_attack_mul(lua_State*)':
questlua_npc.cpp:293: warning: unused variable 'q'
questlua_npc.cpp: In function 'int quest::npc_set_vid_attack_mul(lua_State*)':
questlua_npc.cpp:309: warning: unused variable 'q'
questlua_npc.cpp: In function 'int quest::npc_get_vid_damage_mul(lua_State*)':
questlua_npc.cpp:324: warning: unused variable 'q'
questlua_npc.cpp: In function 'int quest::npc_set_vid_damage_mul(lua_State*)':
questlua_npc.cpp:340: warning: unused variable 'q'
questnpc.cpp: In member function 'bool quest::NPC::HandleEvent(quest::PC&, int)':
questnpc.cpp:500: warning: unused variable 'pPC'
shop.cpp: In member function 'virtual bool CShop::IsSellingItem(DWORD)':
shop.cpp:576: warning: comparison between signed and unsigned integer expressions
FileMonitor_FreeBSD.cpp:136:2: warning: no newline at end of file
ClientPackageCryptInfo.h: In constructor 'CClientPackageCryptInfo::CClientPackageCryptInfo()':
ClientPackageCryptInfo.h:50: warning: 'CClientPackageCryptInfo::m_pSerializedCryptKeyStream' will be initialized after
ClientPackageCryptInfo.h:48: warning:   'int CClientPackageCryptInfo::m_nCryptKeyPackageCnt'
ClientPackageCryptInfo.cpp:9: warning:   when initialized here
In file included from check_server.cpp:1:
check_server.h: In static member function 'static bool CheckServer::CheckIp(const char*)':
check_server.h:24: warning: comparison between signed and unsigned integer expressions
buff_on_attributes.cpp: In member function 'void CBuffOnAttributes::ChangeBuffValue(BYTE)':
buff_on_attributes.cpp:113: warning: unused variable 'old_value'
buff_on_attributes.cpp:114: warning: unused variable 'new_value'
../../../Extern/include/cryptopp/algparam.h: In constructor 'CryptoPP::ConstByteArrayParameter::ConstByteArrayParameter(const T&, bool) [with T = std::basic_string<char, std::char_traits<char>, std::allocator<char> >]':
../../../Extern/include/cryptopp/filters.h:793:   instantiated from here
../../../Extern/include/cryptopp/algparam.h:26: warning: unused variable 'cryptopp_assert_26'
../../../Extern/include/cryptopp/algparam.h: In member function 'void CryptoPP::AlgorithmParametersTemplate<T>::MoveInto(void*) const [with T = CryptoPP::RandomNumberGenerator*]':
cipher.cpp:397:   instantiated from here
../../../Extern/include/cryptopp/algparam.h:322: warning: unused variable 'p'
group_text_parse_tree.h: In constructor 'CGroupTextParseTreeLoader::CGroupTextParseTreeLoader()':
group_text_parse_tree.h:93: warning: 'CGroupTextParseTreeLoader::m_dwcurLineIndex' will be initialized after
group_text_parse_tree.h:91: warning:   'CGroupNode* CGroupTextParseTreeLoader::m_pRootGroupNode'
group_text_parse_tree.cpp:5: warning:   when initialized here
group_text_parse_tree.cpp: In member function 'bool CGroupTextParseTreeLoader::LoadGroup(CGroupNode*)':
group_text_parse_tree.cpp:99: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.cpp: In member function 'bool CGroupNode::GetRow(int, const CGroupNode::CGroupNodeRow**) const':
group_text_parse_tree.cpp:206: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::ReadAdditionalApplys()':
dragon_soul_table.cpp:223: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckApplyNumSettings()':
dragon_soul_table.cpp:283: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckWeightTables()':
dragon_soul_table.cpp:311: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckRefineGradeTables()':
dragon_soul_table.cpp:343: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp:372: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckRefineStepTables()':
dragon_soul_table.cpp:397: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp:427: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckRefineStrengthTables()':
dragon_soul_table.cpp:453: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckDragonHeartExtTables()':
dragon_soul_table.cpp:494: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp:513: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp:522: warning: comparison between signed and unsigned integer expressions
dragon_soul_table.cpp: In member function 'bool DragonSoulTable::CheckDragonSoulExtTables()':
dragon_soul_table.cpp:545: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(const std::string&, T&) const [with T = std::string]':
dragon_soul_table.cpp:129:   instantiated from here
group_text_parse_tree.h:220: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(const std::string&, T&) const [with T = BYTE]':
dragon_soul_table.cpp:134:   instantiated from here
group_text_parse_tree.h:220: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(const std::string&, T&) const [with T = int]':
dragon_soul_table.cpp:201:   instantiated from here
group_text_parse_tree.h:220: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(const std::string&, T&) const [with T = float]':
dragon_soul_table.cpp:260:   instantiated from here
group_text_parse_tree.h:220: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = float]':
dragon_soul_table.cpp:828:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = int]':
group_text_parse_tree.h:159:   instantiated from 'bool CGroupNode::GetValue(const std::string&, const std::string&, T&) const [with T = int]'
group_text_parse_tree.h:203:   instantiated from 'bool CGroupNode::GetGroupValue(const std::string&, const std::string&, const std::string&, T&) const [with T = int]'
dragon_soul_table.cpp:612:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = unsigned int]':
group_text_parse_tree.h:159:   instantiated from 'bool CGroupNode::GetValue(const std::string&, const std::string&, T&) const [with T = unsigned int]'
group_text_parse_tree.h:203:   instantiated from 'bool CGroupNode::GetGroupValue(const std::string&, const std::string&, const std::string&, T&) const [with T = unsigned int]'
dragon_soul_table.cpp:884:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
DragonSoul.cpp: In function 'int Gamble(std::vector<float, std::allocator<float> >&)':
DragonSoul.cpp:19: warning: comparison between signed and unsigned integer expressions
DragonSoul.cpp:25: warning: comparison between signed and unsigned integer expressions
DragonSoul.cpp: In member function 'bool DSManager::Refre........emAttributes(CItem*)':
DragonSoul.cpp:203: warning: comparison between signed and unsigned integer expressions
DragonSoul.cpp: In member function 'bool DSManager::PutAttributes(CItem*)':
DragonSoul.cpp:273: warning: comparison between signed and unsigned integer expressions
DragonSoul.cpp: In member function 'bool DSManager::ExtractDragonHeart(CHARACTER*, CItem*, CItem*)':
DragonSoul.cpp:350: warning: unused variable 'sum'
DragonSoul.cpp: In member function 'bool DSManager::PullOut(CHARACTER*, TItemPos, CItem*&, CItem*)':
DragonSoul.cpp:435: warning: unused variable 'dwVnum'
DragonSoul.cpp:469: warning: format '%d' expects type 'int', but argument 3 has type 'double'
DragonSoul.cpp:469: warning: format '%d' expects type 'int', but argument 4 has type 'double'
char_dragonsoul.cpp: In member function 'bool CHARACTER::DragonSoul_ActivateDeck(int)':
char_dragonsoul.cpp:83: warning: control reaches end of non-void function
DragonSoul.cpp: In member function 'bool DSManager::DoRefineGrade(CHARACTER*, TItemPos (&)[15])':
DragonSoul.cpp:555: warning: unused variable 'prob_sum'
DragonSoul.cpp: In member function 'bool DSManager::DoRefineStep(CHARACTER*, TItemPos (&)[15])':
DragonSoul.cpp:763: warning: unused variable 'sum'
shopEx.cpp: In member function 'virtual int CShopEx::Buy(CHARACTER*, BYTE)':
shopEx.cpp:159: warning: comparison between signed and unsigned integer expressions
item_manager_read_tables.cpp: In member function 'bool ITEM_MANAGER::ReadMonsterDropItemGroup(const char*)':
item_manager_read_tables.cpp:637: warning: unused variable 'pkGroup'
shop_manager.cpp: In function 'bool ConvertToShopItemTable(CGroupNode*, TShopTableEx&)':
shop_manager.cpp:473: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = unsigned int]':
group_text_parse_tree.h:175:   instantiated from 'bool CGroupNode::GetValue(const std::string&, int, T&) const [with T = DWORD]'
shop_manager.cpp:381:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = std::basic_string<char, std::char_traits<char>, std::allocator<char> >]':
group_text_parse_tree.h:175:   instantiated from 'bool CGroupNode::GetValue(const std::string&, int, T&) const [with T = std::string]'
shop_manager.cpp:387:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
group_text_parse_tree.h: In member function 'bool CGroupNode::CGroupNodeRow::GetValue(int, T&) const [with T = unsigned char]':
group_text_parse_tree.h:136:   instantiated from 'bool CGroupNode::GetValue(size_t, const std::string&, T&) const [with T = BYTE]'
shop_manager.cpp:442:   instantiated from here
group_text_parse_tree.h:228: warning: comparison between signed and unsigned integer expressions
In file included from main.cpp:90:
check_server.h: In static member function 'static bool CheckServer::CheckIp(const char*)':
check_server.h:24: warning: comparison between signed and unsigned integer expressions
item_manager_read_tables.cpp:627: warning: 'pkGroup' may be used uninitialized in this function
../../../Extern/include/cryptopp/misc.h: At global scope:
../../../Extern/include/cryptopp/misc.h:547: warning: 'std::string CryptoPP::StringNarrow(const wchar_t*, bool)' defined but not used

There are a lot of warnings, but I hope you can help me.

[Salem]

I dunno, find better code to copy from perhaps?

This isn't a forum where you can just dump a bunch of warnings for some code you "found" and then expect us to fix it for you.

Learn how to program, then you can fix it yourself. If you get stuck on one particular message, then we'll be happy to help.
But dumping 200+ lines of error log, then yelling at us in a large font (now fixed) will just get you ignored.

[RebootS]

Yes Salem.


ok, thank you. Do not expect me to help me, asking too much ....
I've already done 25% of them alone. . .


When you do not understand something, get back in topic

[Elysia]

This smells like C developers writing (or trying to) C++...

[stahta01]

This smells like C developers writing (or trying to) C++...

Not really a good C developer because and half way good one can fix this warning.

char_item.cpp:2389: warning: format '%d' expects type 'int', but argument 6 has type 'long int'

scanf - C++ Reference
printf - C++ Reference

Tim S.

[stahta01]

Please tell me what is hard to understand about this message!!

char_item.cpp:7917: warning: unused variable 'itemType'

Tim S.

[RebootS]

Please tell me what is hard to understand about this message!!

char_item.cpp:7917: warning: unused variable 'itemType'

Tim S.

Do not get me wrong. I'm not a programmer, I do not know c ++.


Do not know how to fix these warnings.
I just know I change the source that I need.

So what should you do to fix those warnings? Unused variable?

[Elysia]

Same as in any other programming language!
Check: Did you mean to use the variable but misspelled it or used another variable instead of it (unintentionally)? If so, fix the bug.
Otherwise, the variable is not used anywhere, so remove it.

[laserlight]

Do not get me wrong. I'm not a programmer, I do not know c ++.


Do not know how to fix these warnings.
I just know I change the source that I need.

So what should you do to fix those warnings? Unused variable?

You should hire a programmer to fix those warnings for you. However, this is not the right place to do that. We do have a Projects and Job Recruitment forum that arguably might be the place to post such a request, but whether people will take you up on the project job offer is another matter. Alternatively, you could take Salem's suggestion on learning how to program, in which case the "I'm not a programmer, I do not know C++" excuse becomes irrelevant as you will need to take small steps to learn what these warnings mean and how to fix them.

That said, note that warnings indicate potential problems with the code. Not all warnings actually mean that there's a problem that will affect the code when run, e.g., the "unused variable" warning could possibly be ignored with no significant negative consequences.

[RebootS]

Ok, who is interested to help? Can I pay for these fixes.

[Elkvis]

Every single warning in that list is one hundred percent self-explanatory. Read them! If you read them and can't understand, then you need to work on your reading comprehension skills. It's plain English language. Since English is pretty clearly your first language, you need to just read and understand these things. I don't know how to explain more clearly than the compiler did when it gave you this output.

[RebootS]

Every single warning in that list is one hundred percent self-explanatory. Read them! If you read them and can't understand, then you need to work on your reading comprehension skills. It's plain English language. Since English is pretty clearly your first language, you need to just read and understand these things. I don't know how to explain more clearly than the compiler did when it gave you this output.

You can add me on skype messenger usa?
YM: pride_dv
Skype: pride_dv

[Elkvis]

You can add me on skype messenger usa?
YM: pride_dv
Skype: pride_dv

No. I don't use Skype or Yahoo Messenger.

[RebootS]

No. I don't use Skype or Yahoo Messenger.

Send me a private message, to talk about this source.

[Elkvis]

Send me a private message, to talk about this source.

I also don't provide private help without payment. And even then, I still won't do your work for you.