Binary File Errors

**bilgramiraza** · 08-11-2014

For a big project for school I have to make an airline reservation simulator but I have run into a problem. I want to save the the flight code and its location in a binary file so that I can obtain a code according to the location but this happens:

The current output
Binary File Errors-wxpkxpo-png

expected output

Binary File Errors-tjwtnde-png

Here is the source class

Code:

 class file
{
    private:


    char code[8];
    char from[20];
    public:
        void input();
        void show();
        char *getn()
        {
            return code;
        }
};file fileobj;


void file::input()
{
    clrscr();
    cout<<"Enter Code+ no: ";
    gets(code);
    int A=strlen(code);
    if(A==6)
        strcat(code,"  ");
    else
        strcat(code," ");
    cout<<"Enter Location: ";
    gets(from);
    int a=20-strlen(from);
    for(int i=0;i<a;i++)
          strcat(from," ");
}
void file::show()
{
    cout<<"Code: ";puts(code);
    cout<<"\t\tLocation: ";puts(from);
}

**Matticus** · 08-11-2014

Please don't make duplicate posts. Give people some time to find and answer your question.

**bilgramiraza** · 08-11-2014

how to delete the current post then?

**Elysia** · 08-11-2014

I think you need to decide on whether to use C or C++ first.

**bilgramiraza** · 08-11-2014

i will be programming in C++ but old standards which work with borland 5.02

**Elysia** · 08-11-2014

Why old standards? Is it a requirement for your school?

**hk_mp5kpdw** · 08-11-2014

FWIW, your code variable is 8 characters and you are treating it as a C-style string when printing using puts which means that it can only reasonably store 7 characters (with the remaining one being a null terminating char). When you use the strcat function to add 2 characters to something that is already 6 characters, you completely fill the 8 available characters such that it does not represent a proper C-style string. You obliterate the location variable as well making it useless as a C-style string.

You should use C++ std::string objects to store this information, or at the very least stop trying to concatenate too much data into strings that are too small. If the purpose of the concatenation is to make things align when printing, then you can use printf with width/alignment format specifiers to do the printing.

BTW, this:

Code:

char *getn()
{
    return code;
}

is dangerous because you expose a raw pointer into your object's data.

**bilgramiraza** · 08-11-2014

Increased the size by 1 and the program works thankyou so much

**Elysia** · 08-11-2014

Your code have a ton of problems. So again, I ask: why old standards? Is it a requirement for your school?

**stahta01** · 08-11-2014

Originally Posted by bilgramiraza

i will be programming in C++ but old standards which work with borland 5.02

Do you know of a place to get a free and legal copy of borland 5.02?

I have an embedded board that uses a highly modified version of borland 5.02 as the Compiler.
I thought maybe a copy borland 5.02 would help learn what works and does not work with it.

Hint: on your issue I suggest using strncpy instead of strcpy; or using std::string.

Tim S.

**bilgramiraza** · 08-18-2014

YUP

Thread: Binary File Errors

Thread Tools

Search Thread

Display

Binary File Errors

Similar Threads

Binary File Errors

store data in binary file then use binary file to find inverse of matrix form of data

Binary file write by user input then printing binary file data out

Reading an IR Spectrosopy File (.SPA file) (Unknown Binary File)

oprantds errors of type int and const char [31] to binary???

Tags for this Thread