Hello, I am in my first year studying computer science so I'm pretty new to coding, I am trying to read user input into a string and then copy that to a c-string, but my c-string keeps showing junk at the end. I have spent over an hour trying to figure this out.
Last edited by cm4424; 02-05-2014 at 01:21 PM.
Just use the c_str() function of std::string. But why do you need a C-string in the first place?
Also post your code on the board, if possible, using code tags.
Originally Posted by Adak
All you have is an array of characters, not a properly terminated C-style string. A proper C-style string is one where there is a terminating null character. The "junk" you see is because you lack this null character... when printing a char array the output will continue character-by-character until you happen upon a random null somewhere in memory. You aren't allocating enough memory (+1 for that missing null) and you then need to set that last character to '\0' for it to be considered a true string in C.Code:char *String1Ptr; char *String2Ptr; char *String3Ptr; string temp; cout << "Please enter the first sentence."; getline(cin, temp); int tempLength=(temp.length()); String1Ptr = new char[tempLength]; for(int i = 0; i < tempLength; i++) { String1Ptr[i] = temp[i]; };
"Owners of dogs will have noticed that, if you provide them with food and water and shelter and affection, they will think you are god. Whereas owners of cats are compelled to realize that, if you provide them with food and water and shelter and affection, they draw the conclusion that they are gods."
-Christopher Hitchens
Elysia--this is for a project to familiarize us with c-strings, sorry about not posting my code on the board, this is my first post.
hk_mp5kpdw--thank you for the explanation.
and thank you both for taking the time to help out a beginner.
Is this a specific school course? So I can recommend people to avoid it.
