Thread: Problem in getting "<< gets(string)" to workout

First, it's getline, not gets -- FAQ > Why gets() is bad / Buffer Overflows - Cprogramming.com. Second, mixing getline (which is line-oriented) with << (which is ... ... data-field-oriented, I guess) is going to cause you to have to work a little harder; << leaves the newline character behind (since it's not part of the account number), which means getline sees the newline character and stops, since it's read an entire line. If you just want to make what you have work, you can add an ignore() call before the getline to get rid of the extra newline.

Originally Posted by tabstop

First, it's getline, not gets -- FAQ > Why gets() is bad / Buffer Overflows - Cprogramming.com. Second, mixing getline (which is line-oriented) with << (which is ... ... data-field-oriented, I guess) is going to cause you to have to work a little harder; << leaves the newline character behind (since it's not part of the account number), which means getline sees the newline character and stops, since it's read an entire line. If you just want to make what you have work, you can add an ignore() call before the getline to get rid of the extra newline.

Thanks for Providing me an INSIGHT to this Problem but the issue i m is still facing...I am unable to get to the line gets(name) i.e when i enters account no.after being asked the Compiler drives me to enter account type...

Code:

void account::create_account()
 {
     cout<<"\nEnter The account No.";
     cin>>acno;
     cout<<"\nEnter The Name of The account Holder :\n";
     gets(name);
     cout<<"Your name is :";
     puts(name);      //for check purpose but got it empty every time
     cout<<"\nEnter Type of The account (C/S) : ";
     cin>>type;​

If u dont mind and see this snapshot

MoreOver FAQ > Why gets() is bad / Buffer Overflows - Cprogramming.com. arguments me to betterly use fgets() as its buffer safe and no issue of getline is discussed there.so i would anyone suggest me how to add ignore

Originally Posted by laserlight

No, tabstop did not tell you to do that. tabstop wrote: "If you just want to make what you have work, you can add an ignore() call before the getline to get rid of the extra newline."

Unless you have special reasons to do so, do not mix C-style and C++-style standard I/O. I would expect something along these lines:

Code:

void account::create_account()
{
    cout << "\nEnter The account No.";
    cin >> acno;
    cout << "\nEnter The Name of The account Holder :\n";
    cin.ignore();
    getline(cin, name);
    cout << "Your name is :" << name;
    cout << "\nEnter Type of The account (C/S) : ";
    cin >> type;

I have used the version of getline for std::string, because name should be a std::string (and if it isn't, you should either have a good reason for that, or fix it). Of course, you should perform error checking in case the user enters invalid input, and perhaps call cin.ignore with specific arguments to cater for the possibility that there's more whitespace to discard.

i have a look at here but the writer have made things very much messy ...so what i got basically for flushing the input is to add

Code:

#include <ios>
    #include <istream>
    #include <limits>   
void ignore_line ( std::istream& in ) {   
in.ignore ( std::numeric_limits<std::streamsize>::max(), '\n' );
 }

Should i go for?

Thanks i have done with..here is what i edited and am presenting here for assistance to anyone who faces the same problem in future.

Code:

cout<<"\nEnter The account No.";
cin>>acno; 


cout<<"\n Enter The Name of The account Holder :\n";
std::cin.ignore ( numeric_limits<std::streamsize>::max(), '\n' );
getline(cin,name);
cout<<"Your name is :"<<name;

The Helping material in this regard besides the respected forum members were from here.