Thread: Linked List not working again:

My else statement in the LinkedLists is crashing the program. I get EXC_ACCESS error on my compiler on head->num=temp->num;

Code:

void ListHandling::LinkedLists(NodePtr temp)
{
    temp = NULL;
    
    if (head!=NULL) {
        current=head;
        
        while (current->next != NULL) {
            current=current->next;
        }
        current= new node;
        current->num= temp->num;
        current->next->next=nullptr;
    }
    else
    head = new node;
    head->num=temp->num;
    head->next=nullptr;

}

Code:

void ListHandling::PrintLinkedLists()
{
    current=head;
    if (head==nullptr) {
        std::cout<<"The list is empty"<<std::endl;
    }
    else
        while (current!=NULL) {
            std::cout<<current->num<<",";
            current=current->next;
        }

}

In main()

Code:

NodePtr temporary = new node;
    
    for (int i=1; i<20; ++i) {
        temporary->num = i;
        Mylists.LinkedLists(temporary);
    }
    
    Mylists.PrintLinkedLists();

Code:

typedef  struct node{
    int num;
    node* next;
}*NodePtr;

class ListHandling {
private:
    std::vector<int> List3;
    
    struct sorting{
        bool operator () (int i, int j) {return (i<j);}
    } ComparedTo;
    
    NodePtr head;
    NodePtr current;
    
public:
    ListHandling();
    ListHandling(std::vector<int>lst3)
    :List3(lst3)
    {
        head=NULL;
        current=NULL;
    
    }
    void MergeLists(std::vector<int>& ,std::vector<int>& );
    void SortLists();
    void PrintSortedList();
    void MergeArray(std::array<int, 5>&,std::array<int, 5>&);
    
    void LinkedLists(NodePtr);
    void PrintLinkedLists();
    
};

Code:

 NodePtr head;
 NodePtr current;

Not pointers, these are variables. I believe you want pointers here.

Code:

typedef  struct node{
    int num;
    node* next;
}*NodePtr;

I did this for that

From my understand all that does is mean you can use NodePtr or node to refer to that structure. It does not mean you no longer have to declare pointers to that structure as pointer. I may be mistaken, but given the error you are receiving I'm inclined to believe I am correct here.

I have used this method a lot when making linked lists. I think my issue is how I am sending the function values in main with the loop. I am continuing to work it.

Wow, I missed this one the first read through.

Code:

temp = NULL;

in your first code bracket line 3. Wouldn't that set the argument you are passing in to NULL?

YOU WERE RIGHT. The NULL was getting to me... I fixed it now thanks.

Code:

for (int i=1; i<20; ++i){
        temporary->num=i;
        Mylists.LinkedLists(temporary);
    }

Is this a wrong way to send a bunch of numbers to the function fast? Because it is only printing out the number 1;

Wow never seen it done like that... I love this website!!!!!!

I am still trying to tackle

Code:

 NodePtr temporary = new node;
    
    for (int i=1; i<20; ++i){
        temporary->num = i;
        Mylists.LinkedLists(temporary);
    }

Code:

std::cout<<"Printing linked list: \n";
    Mylists.PrintLinkedLists();

It is printing out the number 1

Here is what has me puzzled when I take the function outside the loop it equals 19, which makes sense. However when I leave it in the loop it returns 1. That is what is getting me. Example:

Code:

NodePtr temporary = new node;
    
    for (int i=1; i<20; ++i){
        temporary->num = i;
        Mylists.LinkedLists(temporary);
    }
    std::cout<<"Printing linked list: \n";
    Mylists.PrintLinkedLists();

Code:

NodePtr temporary = new node;
    
    for (int i=1; i<20; ++i){
        temporary->num = i;
      
    }
    Mylists.LinkedLists(temporary);
    
    std::cout<<"Printing linked list: \n";
    Mylists.PrintLinkedLists();

No that did not work....

Code:

void ListHandling::LinkedLists(int x)
{
    
    if (head!=NULL) {
        current=head;
        
        while (current->next != NULL) {
            current=current->next;
        }
        current= new node;
        current->num = x;
        current->next=nullptr;
    }
    else
    {
    head = new node;
    head->num = x;
    head->next=nullptr;
    }
}