Thread: Problem regarding the coding error !

hi , i'm using the Borland C++ builder for programming and i've been trying to resolve this issue as whenever i try to run it, it gives me an error.

This code is supposed to do is if you press on “Accept” button, the entered number will be sent to the array named A1 and it should validate the number and the Accept button will be disabled after you accept five numbers.
If you press on “Exc” button, the lower number in the array A1 will be found and it will be displayed in the memo.

And it has one one editbox named Edit1 that holds the input number and one memo named Memo1 and two buttons named Accept and Exc. And i already have declared array of 5 integers initialized by zeros.

Code:

int num;
int A1[5]= {0, 0, 0, 0, 0 };
int i;
int j;
int count;


void __fastcall TForm1::AcceptClick(TObject *Sender)
{
           num=Edit1->Text.ToInt();   
       A1[i] = num;  
       count++; 


if (count==5)  
        Accept->Enabled=false;   




}
//---------------------------------------------------------------------------


void __fastcall TForm1::ExcClick(TObject *Sender)


{
min=A1[0] 
            for(int j=1; j<5; j++)  
            {
                   if(A1[j] < min)   
            min= A1[j]; 
            }
    Memo1->Lines->Add(AnsiString(num));  


}

Your help would be highly appreciated !

Why do you have both i and count?

because all variables and objects need to declared and initialized.

Originally Posted by naughtyaashiq

because all variables and objects need to declared and initialized.

That ... what? That doesn't really answer the question of why do you have both i and count? Sometimes you use i, sometimes you use count, therefore neither of them have the values that they (both) should have. You need to pick one of them, and just use that one consistently.

I'm sorry but what value and how? i mean if i just choose the just the "i".

Originally Posted by naughtyaashiq

I'm sorry but what value and how? i mean if i just choose the just the "i".

Well, look at where they're used:

Code:

  A1[i] = num;  
       count++;

You add one to count, but never to i, so you never move through the array.

pls advise how do i do it ?

Originally Posted by naughtyaashiq

pls advise how do i do it ?

Pick one of "i" and "count" and use it consistently. Do not use both i and count. Pick one.

Originally Posted by ~Kyo~

i is never init... god knows where that data is going... unless he is in debug then I am slightly learning towards the 0 element each time. He defines j as an int twice as well we aren't getting the whole story here. We can't even be entirely sure he doesn't assign count to i somewhere.

If i is truly global as shown, then it is auto initialized to 0.