Thread: vector delete not functioning...

My delete is not working. Why?

Code:

struct MatchName
{
    MatchName(string& searchName) : s_(searchName) {}
    bool operator()(const clsStudent* student) const
    {
        return student->getName() == s_;
    }
    private:
    string s_;
};

void deleteStudent(vector <clsStudent*>& student)
{
    string nameToDelete;
    if (!(student.empty()))
    {
        cout << "\nEnter name of student to delete: " << endl;
        cin >> nameToDelete;
        remove_if(student.begin(), student.end(), MatchName(nameToDelete));
        cout << "Student " << nameToDelete << " deleted.";
    }
    else{
        cout << "\nUnable to perform selected action.";
        cout << "\nThere is " << student.size() << " of students to delete\n" ;
    }
}

On a side note shouldn't you verify the student does indeed exist within the vector before attempting to delete it?

Originally Posted by laserlight

That's effectively what remove_if does when used in conjunction with erase.

Ok, I just looked up erase to expand my own understanding in C++. I see what your saying now. Erase will fix his problem as well as what I was seeing as a possible problem in the future.