Thread: Reading a mpeg video file

i have been working with vidoe files and my task is open a video file, get it copied into another file and then changing into binay format. after getting few bits inverted, changing back it into ascii formats. original video contains normal and extended ascii codes. unfortunately, i got stuck at first step, whole video file is not being copied. i have wirtten a piece of code that copies the whole word/ any text file but the video file is not fully copied as just 5KB out of 119,659 KB are copied. plz see the code and help me out

Code:

#include "stdafx.h"
int _tmain(int argc, _TCHAR* argv[])
{


FILE *fp1,*fp2;
    
    char c;


    fp1 = fopen( "sample.mpg", "r") ;
    fp2 = fopen("result.txt","w");
    c = getc(fp1) ;    
        while ( c != EOF) 
        { 
            putc( c,  fp2);
            c =  getc( fp1 ) ;
        } 


fclose ( fp1 );
fclose(fp2);
}

Originally Posted by Afzaal Ahmed

it returns the characters it read, but fails after reading about 1/4 of a video file

it returns int and you store it into char
so when char value 0xFF is read and compared to EOF (-1) - your loop is broken.
make c an int.

change the mode to rb and wb correspondingly

Originally Posted by Afzaal Ahmed

i have mistakenly declared c as a character here, in the original code c is actually an integer. But this problem persists for c as an int and it is only for the video files while any text file is fully copied.

You need to open your files in binary mode, ie: "rb" and "wb" as opposed to "r" and "w".

> #include "stdafx.h"
> int _tmain(int argc, _TCHAR* argv[])
Ah, windows user.

In which case, you need to use "rb" and "wb" as your file open modes to force the file to be read as binary data.

If you read binary data in text mode, the first 0x1A byte it sees signals EOF.

Originally Posted by Salem

If you read binary data in text mode, the first 0x1A byte it sees signals EOF.

And 0x0D 0x0A (aka, '\r' '\n') combinations will be changed to 0x0A.