Thread: Need help with my simple If statement & Boolean (Noob sos)

Indent style - Wikipedia, the free encyclopedia

usingnamespacestd; - 2 spaces missing

((x && y) > 100) - you need to read about logical operators and how they work

why your main returns something only in particular cases? return statement should be unconditional

Originally Posted by whiteflags

>> I can't get the last statement if/else statement to work.
The expression being tested is:
(x && y) > 100
(x && y) is true if both x and y are nonzero, so that becomes 1 > 100, which is never true.
You probably meant x > 100 && y > 100, where each side of the expression is tested, and both must be true.

The other aspect is that if/else if/else if are evaluated sequentially. if x is 200 and y is 300, the code will only report that one is older than the other (no mention of "crazy old" which might also be intended).

Originally Posted by vart

why your main returns something only in particular cases? return statement should be unconditional

The "should be" is open to interpretation but, in C++, falling off the end of main() is equivalent to return 0. So it makes no real difference in this example, but would be broken in a function other than main().

Hey guys thanks for all the feedback.. I have rewritten the code and it looks like this now:

Code:

#include <iostream>
#include <string>


usingnamespacestd;


int main ()


{
    string name; // x
    string name_2; // y
    int x;
    int y;

cout << "Hello User.. This program intend's to ask for the age and name of 2 people\n";

cout << "Please enter the first name:\n";
    getline(cin, name, '\n');

cout << "Good.. now enter the age of " << name << ":\n";
    cin >> x;
    cin.ignore();

cout << "Next I need you to enter the name of person number 2:\n";
    getline(cin, name_2, '\n');

cout << "Alright.. now finally please enter the age of " << name_2 << ":\n";
    cin >> y;

    if (x > y)
        cout << name << " is older than " << name_2 << "\n";
    else if (y > x)
        cout << name_2 << " is older than " << name << "\n";
    else
        return 0;

    if ( x > 100 && y > 100)
cout << "You're both crazy old!!!\n";





}

Program runs like this:

[Program]
Hello User.. This program intend's to ask for the age and name of 2 people
Please enter the first name:
Jonathan
Good.. now enter the age of Jonathan:
155
Next I need you to enter the name of person number 2:
Mike
Alright.. now finally please enter the age of Mike:
141
Jonathan is older than Mike
You're both crazy old!!!
Program ended with exit code: 0
[/Program]

Wow this stuff really pounds logic to my head. Never even imagined that the <enter> key also inputs a "\n" as well.

I also had been able to fix the order of operations for (x && y > 100) and realized that was only half the problem with the "If/else" statement only choosing one possibility while it was possible to have 2 at the same time. (being old and choosing who is older)

I hope this new code I wrote is working for all the reasons I think it should and not by accident! ^^

//Side-note: I have changed the spelling of "Your" to "You're" & "usingnamespacestd" was a typo (I know I need 2 spaces.. ^^ )

Try entering both ages as 102, and see what happens. You won't get much output.

Originally Posted by grumpy

Try entering both ages as 102, and see what happens. You won't get much output.

Thanks for pointing that out. : ) For some reason I had the impression that the "if/else" statement needed to be ended with "else" so I used "return 0." After running some test I found out that I could omit the "else" statement entirely.

This is now my new code:

Code:

#include <iostream>
#include <string>


usingnamespacestd;


int main ()


{
    string name; // x
    string name_2; // y
    int x;
    int y;

cout << "Hello User.. This program intend's to ask for the age and name of 2 people\n";

cout << "Please enter the first name:\n";
    getline(cin, name, '\n');

cout << "Good.. now enter the age of " << name << ":\n";
    cin >> x;
    cin.ignore();

cout << "Next I need you to enter the name of person number 2:\n";
    getline(cin, name_2, '\n');

cout << "Alright.. now finally please enter the age of " << name_2 << ":\n";
    cin >> y;

    if (x > y)
        cout << name << " is older than " << name_2 << "\n";
    else if (y > x)
        cout << name_2 << " is older than " << name << "\n";
    else if (x == y)
cout << "Your both the same age!!\n";


    if (( x > 100 && y > 100) && x == y)
cout << "And You're both crazy old!!\n";
    else if ( x > 100 && y > 100)
cout << "You're both crazy old!!!\n";


}

[Test 1]
Hello User.. This program intend's to ask for the age and name of 2 people
Please enter the first name:
Jonathan
Good.. now enter the age of Jonathan:
102
Next I need you to enter the name of person number 2:
Mike
Alright.. now finally please enter the age of Mike:
102
Your both the same age!!
And You're both crazy old!!
Program ended with exit code: 0
[/Test 1]

[Test 2]
Hello User.. This program intend's to ask for the age and name of 2 people
Please enter the first name:
Jonathan
Good.. now enter the age of Jonathan:
21
Next I need you to enter the name of person number 2:
Mike
Alright.. now finally please enter the age of Mike:
21
Your both the same age!!
Program ended with exit code: 0
[/Test 2]



I really appreciate the learning value I get from your help!

you should pass your code as text

Code:

#include <iostream>
#include <string>

using namespace std;

int main ()
{
    string name; // x
    string name_2; // y
    int x;
    int y;

    cout << "Hello User.. This program intend's to ask for the age and name of 2 people\n";

    cout << "Please enter the first name:\n";
    getline(cin, name, '\n');

    cout << "Good.. now enter the age of " << name << ":\n";
    cin >> x;
    cin.ignore();

    cout << "Next I need you to enter the name of person number 2:\n";
    getline(cin, name_2, '\n');

    cout << "Alright.. now finally please enter the age of " << name_2 << ":\n";
    cin >> y;

    if (x > y)
        cout << name << " is older than " << name_2 << "\n";
    else if (y > x)
        cout << name_2 << " is older than " << name << "\n";
    else if (x == y)
        cout << "Your both the same age!!\n";


    if (( x > 100 && y > 100) && x == y)
        cout << "And You're both crazy old!!\n";
    else if ( x > 100 && y > 100)
        cout << "You're both crazy old!!!\n";
}

Apart from the formatting concern, your code (as posted) isn't valid, as "elseif" is not a keyword.

That aside, try simplifying the two if/else blocks. Both have a lot of duplicated parts. Removing the duplication will make the logic simpler.