Nested Class Construction problem

[Trey Brumley]

In this program, we use nested classes to represent rooms and customers in hotels. My current problem occurs in implementation, but I'm including the header file in case you guys see an error I don't in that.

My error comes in the implementation where I try to construct a customer with strings x and y. At x, there's a red line with the notation "Expected a ')'"; at y, there's a red line with the notations "this declaration has no storage class or type specifier"; and at the second ), the notation states "this declaration has no storage class or type specifier; expected a ';'".

What's causing this an how can I fix it?

Here is the header.

#pragma onceclass hotel
{


public:
    hotel(void);
    ~hotel(void);
    class customer
    {
        const string name;
        string CCNum;
    public:
        customer(string x, string y);
        ~customer(string x, string y);
        void changeCCNum (string x);
        void getCCNum (string x);
        void getName (string y);
        void printReceipt (double z, string x);
    };
    class room
    {
        const int RNum;
        const bool isSmoking;
        double bill;
        int occNum;
        int nights;


    public:
        room(int x, bool y);
        ~room(void);
        double getBill(int x, int y);
        int getNights(int x);
        int setNights(int x);
        int getOccNum(int y);
        int setOccNum(int y);
    };
};

Here is the implementation as I have it so far.

#include "hotel.h"#include <string>


hotel::hotel(void)
{
}


hotel::~hotel(void)
{
}


hotel::customer(string x, string y)
{
    name = x;
    CCNum = y;
}




hotel::~customer(void)
{
}


hotel::room(int x, bool y)
{
    RNum = x;
    isSmoking = y;
}


hotel::~room(void)
{
}

[jimblumberg]

You are miss-scoping your room constructor, room is not part of the hotel class but it's own class:

room::room(int x, bool y)
{
    RNum = x;
    isSmoking = y;
}

Also you should start using initialization lists:

room::room(int x, bool y) : RNum(x), isSmoking(y) , bill(0.0), occNum(0), nights(0)
{
   // Blank body.
}

Jim

[vart]

since it is nested class it would be

hotel::room::room(int x, bool y):RNum(x),isSmoking(y), bill(0.0), occNum(0), nights(0)
{
}

Also in C++ you do not need to add void for empty parameter list

And destructor cannot have parameters

P.S. parameter names like x and y are not very descriptive - your function will not be usable without documentation

[hk_mp5kpdw]

1. Your class header needs to include the <string> header
2. You then need to reference std::string instead of just string within said header... avoid putting a using namespace std statement in the header (at least at file scope).
3. Your "get" functions should probably return a value and not rely on a passed in argument. You're doing it wrong anyway if that's what you do intend, the arguments would need to be passed by non-const reference.
4. The "get" member functions should be declared as const member functions.
5. The std::string objects being passed around should be passed as const reference parameters unless you intend to modify the arguments.
6. As hinted at, you should prefer initialization lists in your constructors... in fact, you will be required to use them to initialize your const data members.