Code:#include<iostream.h> #include<conio.h> class item{ public: char name[20]; int price[10]; void enter(); }; void item::enter() { for(int i=0;i<5;i++){ cout<<"\nEnter name of Item "<<(i+1); cin>>name[i]; cout<<"\nEnter the price in Rs : "; cin>>price[i]; } } void main() { clrscr(); int a; item chips; chips.enter(); cout<<"/nEnter the max price : "; cin>>a; for(int j=0;j<5;j++){ if(chips.price[j]<=a) cout<<"/n"<<chips.name[j]; } getch(); }
the loop does not work correctly
please help!
>the loop does not work correctly
So does your indentation!
Also, mind that conio.h is not in the standard (!!!). I would sure not use it if I were you
We also write
instead of main voidCode:int main( ) { .... return 0; }
Code - functions and small libraries I use
It’s 2014 and I still use printf() for debugging.
"Programs must be written for people to read, and only incidentally for machines to execute. " —Harold Abelson
You need to indent your code properly.
This is pre-standard:
It should be:Code:#include<iostream.h>
Oh, and then you will need to qualify names, e.g., write std::cout instead of just cout, or say, place the using directive using namespace std; after the header inclusions.Code:#include <iostream>
This is non-standard, which is sometimes fine:
but you are only using it for getch, which you don't need as you can say, run the program in a command prompt window or use the standard cin.get() instead. Okay, you are also using it from clrscr, but frankly you don't need to do so.Code:#include<conio.h>
Your item class enter member function should not be a member function at all. Furthermore, perhaps if you changed it to take an argument, you would be able to reason about it better. At the moment, you seem to be confused as to whether it works on a single item or many items.
This is wrong:
It should be:Code:void main()
Code:int main()How does it not work?Originally Posted by royroy
Look up a C++ Reference and learn How To Ask Questions The Smart Way
Code:#include<iostream> #include<conio.h> using namespace std; class item{ public: char name[20]; int price; void enter(int); }; void item::enter(int i) { cout<<endl<<"Enter name of Item "<<i<<":"; cin>>name; cout<<endl<<"Enter the price in Rs : "; cin>>price; } int main() { system("cls"); int a; item chips[5]; for(int i=0;i<5;i++) chips[i].enter(i+1); cout<<endl<<"Enter the max price : "; cin>>a; for(int j=0;j<5;j++){ if(chips[j].price<=a) cout<<endl<<chips[j].name; } getch(); return 0; }
You should still indent your code.
You should replace your char array name with std::string. Clearly you are expecting an array of strings and not an array of single characters.
Be sure to take a look at SourceForge.net: Safer arrays in Cpp - cpwiki to see what C++ has to offer in terms of arrays and how dangerous they can be.
Here is some good advice: SourceForge.net: Do not remove parameter names - cpwiki
Also know that system is a potential security risk. You really should avoid it. There is no need to clear the screen.
Finally, consider making your member variables private and add appropriate getter functions to access them.
container.size() is still conspicuously missing as a solution.Be sure to take a look at SourceForge.net: Safer arrays in Cpp - cpwiki to see what C++ has to offer in terms of arrays and how dangerous they can be.
You have a point. I will add a section about legacy interfaces with containers.
