Need help!

[FruixX]

Hello I have made a program that outputs a menu where you can do different things, it does kinda what I want it to do put it feel like you could simplify it somehow. I am new to programming so if someone has any good tip I would aprecciate it!

Here is the code:

#include <iostream>
#include <string>

using namespace std;


int main()
{
    int j;
    string proceed;


    do
    {
         cout << "Here are a list of different choices:\n";
         cout << "\t1. Bajs\n";
         cout << "\t2. Kiss\n";
         cout << "\t3. Neger\n";
         cout << "\t4. Beer song\n";
         cout << "\t0. Quit\n";


         cout << "\nPlease enter one of the number from the list: ";
         cin >> j;
         cout << '\n';


         if ( j == 1 )
         {
             cout << "You are a bajskorv!\n";
         }


         else if ( j == 2 )
         {
             cout << "You like to kissa!\n";
         }


         if ( j == 3 )
         {
             cout << "You are a black independent woman!\n";
         }


         else if ( j == 4 )
         {
             for ( int i = 99; i >= 0; i-- )
             {
                 if ( i == 1 )
                    {
                        cout << i << " bottle of beer on the wall, " << i << " bottle of beer.\n";
                        cout << "Take one down and pass it around, no more bottles of beer on the wall.\n";
                        continue;
                    }


                if ( i != 0 )
                {
                        cout << i << " bottles of beer on the wall, "  << i << " bottles of beer.\n";
                        cout << "Take one down and pass it around, " << i - 1 << " bottles of beer on the wall.\n";
                        cout << '\n';
                }


                if ( i == 0 )
                {
                        cout << '\n';
                        cout << "No more bottles of beer on the wall, no more bottles of bear\n";
                        cout << "Go to the store and buy some more, 99 bottles of beer on the wall.\n";
                }
            }
         }


         if ( j != 1 && j != 2 && j != 3 && j != 4 && j != 0 )
         {
             cout << "Not a valid option, please choose a correct number from the list!";
         }


         if ( j == 0 )
         {
             return 0;
         }


         cout << "\n\n";


         cout << "Do you want to choose another number?\n";
         cout << "y or n: ";
         cin >> proceed;


         if ( proceed == "n" || proceed == "N" )
         {
             cout << "Thank you, come again\n";
             return 0;
         }
         else if ( proceed == "y" || proceed == "Y" )
         {
             cout << "Here you see the list again:\n\n";
         }


         if ( proceed != "y" || proceed != "Y" || proceed != "n" || proceed != "N" )
         {
             int k = 0;
             while ( k == 0)
             {
                 cout << "Not an option, try again!\n\n";
                 cout << "Choose one of the following:s\n";
                 cout << "y or n: ";
                 cin >> proceed;


                 if ( proceed == "n" || proceed == "N" )
                 {
                    cout << "Thank you, come again\n";
                    return 0;
                 }
                 else if ( proceed == "y" || proceed == "Y" )
                 {
                    cout << "Here you see the list again:\n\n";
                 }
             }
        }
    }
    while ( true );
}

[ZuK]

if ( proceed != "y" || proceed != "Y" || proceed != "n" || proceed != "N" )

This line doesn't make sense it is always true.
Kurt

[FruixX]

Yeah i know, I have already changed that

[FruixX]

now I am really confused, this code doesn't work at all. why?

#include <iostream>
#include <string>


using namespace std;


int main()
{
    string password;
    for ( int i = 3; i > 0; i-- )
    {
        cout << "Please enter your password: ";
        getline ( cin, password, 'n' );


        if ( password != "yyz" )
        {
            cout << "wrong password, " << i - 1 << " tries left!\n";
            return 0;
        }


        else
        {
            cout << "You actually entered the correct password, welcome to nothing! ";
            i = 3;
        }
    }
}

[jimblumberg]

getline ( cin, password, 'n' );

Are you entering the character 'n' to end your input? This is not the same as the new line character, which is the default termination character for getline().

Jim

[Elysia]

Also, people generally don't like seeing certain [censored] words. I'd be more considerate with what I type in the future.

[FruixX]

I am sorry for my bad sense of humor, of course I don't want to insult anyone! But I didn't think anyone would recognice swedish words anyway, my bad, sorry!

[Elysia]

I don't you've insulted anyone. Don't worry. I was just giving you a little friendly warning. It's just that, unfortunately, some people do take such things seriously (I'm not one of them, btw).

[Inkinsarto]

Try this:

#include <iostream>
#include <string>
 
 
using namespace std;
 
 
int main()
{
    string std::password;
    for ( int i = 3; i > 0; i-- )
    {
        cout << "Please enter your password: ";
        getline(std::cin, password);
 
 
        if ( password != "yyz" )
        {
            cout << "wrong password, " << i - 1 << " tries left!\n";
            return 0;
        }
 
 
        else
        {
            cout << "You actually entered the correct password, welcome to nothing! ";
            i = 3;
        }
    }
}

[laserlight]

Try this:

#include <iostream>
#include <string>
 
 
using namespace std;
 
 
int main()
{
    string std::password;
    for ( int i = 3; i > 0; i-- )
    {
        cout << "Please enter your password: ";
        getline(std::cin, password);
 
 
        if ( password != "yyz" )
        {
            cout << "wrong password, " << i - 1 << " tries left!\n";
            return 0;
        }
 
 
        else
        {
            cout << "You actually entered the correct password, welcome to nothing! ";
            i = 3;
        }
    }
}

I tried, but...

test.cpp: In function 'int main()':
test.cpp:10:17: error: invalid use of qualified-name 'std::password'
test.cpp:14:27: error: 'password' was not declared in this scope

[Inkinsarto]

try including one of these header files:

#include <algorithm>  
#include <cctype>
#include <windows.h>
#include <stdio.h>    
#include <locale>

[laserlight]

try including one of these header files:

Sigh. Inkinsarto, when you get an error message, your first reaction should not be to include more header files. Rather, you should read the error message and understand what it says.

[Elkvis]

try including one of these header files:

#include <stdio.h>

for C++ it should be <cstdio>

[Inkinsarto]

test.cpp:14:27: error: 'password'was not declared in thisscope

password is still declared, but not in that scope. In other words I thought this meant that either 'password' needed to be defined differently,
or a different header file needed to be added to allow std:: to be used.

[laserlight]

password is still declared, but not in that scope. In other words I thought this meant that either 'password' needed to be defined differently,
or a different header file needed to be added to allow std:: to be used.

This means that you don't understand the code. Look at this snippet:

    string std::password;
    for ( int i = 3; i > 0; i-- )
    {
        cout << "Please enter your password: ";
        getline(std::cin, password);

password is the second argument to getline. We can reason that this means password was intended to be a std::string variable. As such, this line:

string std::password;

should have been:

string password;

In fact, this was what FruixX wrote, and quick check shows that this is the only thing you changed, i.e., you changed the code to make it have an unintended compile error.