Thread: Input/Output Text File Manipulation not working!

Hi guys; I was wondering if you can tell me why my output screen for this program does not want to stay open. It only opens for a split of a second and it's gone. The program is supposed to take numbers from a input file and display and save the manipulation in the output file. Here is the program. Thanks guys.....

Code:

 .#include<iostream>
#include<fstream>
#include<iomanip>
usingnamespace std;
 
int main()
{
//Declares Necessary Variables
ifstream infile;
ofstream outfile;
int inputNumber=0;
int highestNum=-999999;
int lowestNum=999999;
float sum=0;
float average=0;
int currentlineNum=1;
//Opens The Input File
    infile.open("Input_File.txt", ios::in);
if (!infile)
{
        cout << "Sorry, Can Not Open The File" << endl;
        exit (1);
    }
//Opens The Output File
    outfile.open("Output_file.txt", ios::out);
do
    {
//Loops Thru File, Until We Get To The Last Number
        cout << "THE INPUT DATA FOR LINE #" << currentlineNum << " is: ";
        outfile << "THE OUTPUT DATA FOR LINE #" << currentlineNum << " is: ";
for (int counter=1; counter <= 7; counter++)
        {
            infile >> inputNumber;
            sum += inputNumber;//Calculates The Total Sum of #'s For Each Line
//Which Number Is Highest/Lowest
if (inputNumber > highestNum)
            {
                highestNum = inputNumber;
            }
if (inputNumber < lowestNum)
            {
                lowestNum = inputNumber;
            }
//Displays Current Number To The Output Screen
            cout << inputNumber << "\t";
            outfile << inputNumber << "\t";
        }
//Finds The Total Average For Each Line
        average = sum / 7;
        cout << endl;
//Displays Data To The Output Screen
        cout << "\nTHE HIGHEST NUMBER IS: " << highestNum;
        cout << "\nTHE LOWEST NUMBER IS: " << lowestNum;
        cout << "\nTHE TOTAL OF THE NUMBERS IS: " << sum;
        cout << "\nTHE AVERAGE OF THE NUMBERS IS: " << average;
//Outfile Section....Saves Data To The Output File
        outfile << endl;
        outfile << "\nTHE HIGHEST NUMBER IS: " << highestNum;
        outfile << "\nTHE LOWEST NUMBER IS: " << lowestNum;
        outfile << "\nTHE TOTAL OF THE NUMBERS IS: " << sum;
        outfile << "\nTHE AVERAGE OF THE NUMBERS IS: " << average << endl << endl;
//Resets Variables Back To Default Values
        highestNum=-999999;
lowestNum=999999;
sum=0;
average=0;
currentlineNum++;
        cout << endl << endl;   //Places Data On New Line
    }
while (!infile.eof()); //Loop Stops When Reaches The End Of File
    cout << endl << endl << "\tWE HAVE REACHED THE END OF THE FILE." << endl;
    outfile << endl << endl << "\tWE HAVE REACHED THE END OF THE FILE." << endl << endl;
//Closes Input And Output Files
    infile.close();
    outfile.close();
    system ("pause");
return 0;
}

Originally Posted by Frank1234

Code:

while (!infile.eof());

this is the wrong way to detect the end of a file. eof() will only trigger after you reach the end of the file and try to read again. the better way is to check the return value of operator>>.

so instead of

Code:

do
{
} while (!infile.eof());

it would be better to do something more like this

Code:

while (infile >> inputNumber)
{
}

this may be the source of your trouble.

also, when pasting code from visual studio, you should right click and select "paste as plain text" if you have that option. otherwise your code gets polluted with color, font, and size tags, and makes it very difficult to manage when replying.

cin.get();

add this at the end

Originally Posted by pratras

cin.get();

add this at the end

certainly the better solution, but the OP already has this:

Code:

system ("pause");

which does exactly the same thing.

I suspect an exception is being thrown, and you're simply running the program instead of starting it in the debugger.