Thread: Help me! Im noob, 1st yr student in College

If you only want a single message printed, you might consider removing the print statements from the loop.

One approach would be to have a flag that can be updated in the loop. When the loop is complete, you can print a message depending on the status of that flag.

[edit] It's considered bad manners to cross-post your problem all at once. To understand why, you might want to read this: http://www.catb.org/~esr/faqs/smart-questions.html

Print after the loop. Of course, this means that you would say, use a boolean variable as a flag to record whether the target character has been found in the array.

char word[4];
...
for (int x=0; x<5; x++)

You also need to sort out buffer overruns, and the fact that "qwert" won't fit into 4 characters (3 actually, if you allow for the \0 marking the end of the string).

Also cin >> singlechar;
is problematic in that it will probably end up being the \n at the end of the previous input.

Originally Posted by klorcs

insert

Code:

#include <iostream>

using namespace std;

int main ()
{
    char word[4];
    char target;
    cin >> word;
    cin >> target;
    for (int x=0; x<5; x++)
    {
        if (word[x]==target)
        {
           cout << "yes" <<endl;
        }
        else
        {
           cout << "no" <<endl; 
        }
    }
    
    system ("pause");
    return 0;
}

----

output of this is:
qwert (I input)
q (I input too)
yes
no
no
no
no

-----

I want 1 yes only if the target character is in the array but 1 no only if it's not in the array. Hope somebody can answer me, thanks.

Replace
char word[4];
with
std::string word;

Don't forget to include <string>.
This will eliminate buffer overflows.

Replace
for (int x=0; x<5; x++)
with
for (int x=0; x<word.size(); x++)

This will prevent out-of-bounds access and remove the manual responsibility of knowing the size yourself.

Originally Posted by klorcs

1st, I dont know what is buffer overruns, that's why I call myself noob
2nd, qwert is not 4 character, it is 5. But it will fit in word[4] since [4] is index, word[0] is 1 index so as word[1], so it has 5 index.

Your thinking is incorrect.
If the declaration has [4] then there are only 4 indexes. One of those needs to contain he nul-terminator, leaving room for only a 3 character string in indexes [0], [1], and [2].

Besides, it make no sense to go up to any fixed limit in the for loop every time. If I enter a two-letter word, then you only want to check two characters. Thus a better loop would be:

Code:

for (int x = 0; word[x] != '\0'; ++x)

Line 11 is still very dangerous though. You aren't stopping the user from typing more than 3 characters into your buffer. If the user types 100 characters then they will most likely crash your program. Either use setw I think it is, or std::string.