Thread: Undefined reference to struct

edit: gotcha!

forgot to add #include <string> to the header and to compile the two src together.


Good afternoon. I'm getting the error mentioned in the title when I try to pass a struct from golfers which was dinamically created.

Code:

 
#include <iostream> 
#include <string>
#include <cstring>
#include "../Headers/golf.h"

int main() 
{ 
   using std::cout; 
   using std::cin; 
   using std::strlen;
   using std::string; 
   using sport::setgolf;
   using sport::golf; 
   
   string fullname;
   int players, handicap; 
   
   cout << "How many players are playing? "; 
   while(!(cin >> players))
   { 
     cin.clear();
     while(cin.get() != '\n') 
       continue; 
     cout << "Please enter how many players are playing: ";     
   }        
   cin.get();
   golf *golfers = new golf[players];
   for(int i = 0; i < players; i++) 
   { 
      cout << "Enter your full name: "; 
      if(cin.get() == '\n') 
       break; 
      getline(cin, fullname);
      cout << "Enter the handicap: "; 
      (cin >> handicap).get();
      setgolf(golfers[i], fullname, handicap);
   } 
   delete [] golfers;
}

Code:

 
 36: referência indefinida para `sport::setgolf(sport::golf&, std::string, int)'

Code:

 
#include <iostream> 
#include <string>
#include <cstring>
#include "../Headers/golf.h"

namespace sport { 
    
  void setgolf(golf &g, const std::string name, int hc)
  { 
     g.fullname = name;
     g.handicap = hc;      
  }
  
  int setgolf(golf &g)
  { 
    using std::string;
    using std::cout;
    using std::cin; 
    using std::strlen;
    
    cout << "Please enter full name: "; 
    cin >> g.fullname;
    cout << "Please enter handicap: ";
    cin >> g.handicap;  
    if(g.fullname.length() == 0)
     return 0; 
    else 
     return 1;    
  }
  
  void handicap(golf &g, int hc) 
  { 
    g.handicap = hc;  
  }     
  
  void showgolf(const golf &g)
  { 
     using std::cout; 
     using std::endl; 
     
     cout << "Your name: " <<  g.fullname << endl;   
     cout << "Handicap: " << g.handicap << endl; 
  }                           
}

Code:

 
#ifndef GOLF_H_
#define GOLF_H_

const int LEN = 40; 

namespace sport { 

  struct golf { 
    
    std::string fullname; 
    int handicap;    
  };     

    // non-interactive version: 
    // function sets golf structure to provided name, handicap
    // using values passed as arguments to the function
    void setgolf(golf & g, const std::string name, int hc);
    // interactive version:
    // function solicits name and handicap from user
    // and sets the members of g to the values entered
    // returns 1 if name is entered, 0 if name is empty string
    int setgolf(golf & g);
    // function resets handicap to new value
    void handicap(golf & g, int hc);
    // function displays contents of golf structure
    void showgolf(const golf & g);
}    

#endif

Please use std::vector instead of new [].

Originally Posted by Elysia

Please use std::vector instead of new [].

Since he is probably now learning, I would suggest not. Focus on learning the concepts of OOP first thames

Of course it is ok when you are on your first steps. Focus on the concepts of OOP

Elysia knows, of course what she says, but the please at the start of her post, made me post

Originally Posted by std10093

Since he is probably now learning, I would suggest not. Focus on learning the concepts of OOP first thames

Focus on learning how to program C++ properly!
Don't use new unless absolutely necessary.

Originally Posted by thames

I would use std::array. Is that ok? but why?

hey std! long time no see you!

std::array won't work for dynamic arrays.

Originally Posted by Elysia

std::array won't work for dynamic arrays.

I read array instead of std::array thames! I agree with Elysia on that

Originally Posted by std10093

Since he is probably now learning, I would suggest not. Focus on learning the concepts of OOP first

std10093, I suggest that you read Learning Standard C++ as a New Language by Bjarne Stroustrup, the designer and original implementer of C++.