Thread: string to upper

I must be staring at this for too long because Ive been able to do this simple loop in the past...not today. Im just trying to take a string including spaces or characters and convert it to uppercase letters. Where am I going wrong please?

Code:

     cout <<"\nPlease enter your full name: ";
     getline(cin,ch);
     cout << endl;


     for (int x = 0; x < ch.length(); x++) 
     {            //takes each character and converts it to uppercase letters
     cout << (char)(toupper(ch.at(x)));
     }

For a string, use the transform function to uppercase all letters, including those separated by spaces:

Code:

#include<iostream>
#include<conio.h>
#include<algorithm>
#include<string>
using namespace std;

void main()
{
string ch;
cout<<"\nPlease enter your full name: ";
getline(cin,ch);
cout<<endl;
transform(ch.begin(), ch.end(),ch.begin(), ::toupper) //replacement function
cout<<ch;
getch();
}

@confused i hope you see what is the problem with the code of hss