Thread: Palindrome issue

The <string> header is for C++ std::string objects (which you should consider using anyway instead of C style null-terminated char arrays). The proper header for functions such as strlen would be <cstring>.

---

Code:

if(str[i] == ' ')
{
    str[i]='\b';
}

This code is pointless, the data in str is uninitialized at this point in time.

---

Code:

while(str[i])
{
    c=str[i];
    putchar(tolower(c));
    i++;
}

Are you trying to convert all the letters in the user entered string to lower case prior to the comparison loop? All you are doing is outputting to the console, you aren't actually changing the data in str. You probably also want to overwrite the data in str with the lowered chars at this point to ensure your later comparison works regardless of the case entered by the user. This would also be the place to remove any non-alphabetic characters.

---

Code:

#include<conio.h>

...

getch();

There's no need to be using non-standard headers/functions here. You can do without these and simply use a call (or 2) to cin stream's get member function.

---

Code:

using namespace std;
#include<string>

Avoid including any headers after a using namespace std declaration. This is just as risky as putting such a line inside of a header file itself. That line should be after the include, not before it.

---

Your loop comparison, as already mentioned, is flawed. If you got the indexing issue resolved it still looks like you would be outputting a "yes it's a palindrome" or "no it's not a palindrome" message for every character comparison instead of just once.

Your two index variables - y, s - needs to both be modified within the loop. y should increase by 1 and s should decrease by 1.

The loop condition should stop once y is equal to or greater than s. The loop should also stop once it's determined that the string entered by the user cannot possibly be a palindrome due to an unequal char comparison. At that point you would not need to continue making comparisons since we already would know it is not a palindrome.

The loop should alter a flag variable of some kind - bool perhaps, initialized to true. Once a comparison is made that is unequal, you can set the flag variable to false and exit the loop. If no unequal comparisons are made then the flag variable remains unchanged - true.

After the loop you then test the flag variable for true/false and output an appropriate message.

---

You should try learning more about the std::string container and the various stl functions available to you in C++. The std::transform stl function can help you convert everything in the user entered string to lower-case. The std::remove_if function can help get rid of any non-alphabetic characters so you just have a string with a-zA-Z characters. The std::equal function can make the test for palindrome a one-liner. I'm sure there are examples of the use of these functions available here and elsewhere out there on "teh interwebz".