Position of code

[JayCee++]

In the following snippett why do the 4 lines starting 'HANDLE hOut;' have to go inside 'int main()'. I would have thought they should run before it as well but they don't, it gives an error saying 'hOut does not name a type'?

#include <iostream>
#include <windows.h>
#include "ShortColours.h"

using namespace std;

int main()
{
    HANDLE hOut;
    hOut=GetStdHandle(STD_OUTPUT_HANDLE);
    SetConsoleTextAttribute (hOut, BWI | FBI);
    system ("CLS");

[jimblumberg]

You can only call functions from within another function.


Jim

[JayCee++]

Thanks Jim, so that is a function really provided by windows.h.

Pretty obvious I suppose when it is pointed out!

[jimblumberg]

The following are all function calls .

GetStdHandle(STD_OUTPUT_HANDLE);
SetConsoleTextAttribute (hOut, BWI | FBI);
system ("CLS");

Only the first two are prototyped by some include file that is included by windows.h. The final one is prototyped in stdlib.h./

Jim

[antred]

<cstdlib>, actually.

[std10093]

C++ : <cstdlib>
C : <stdlib.h>

[JayCee++]

So is there no way I can make the function universally available in all my functions without including all 4 lines at the start of each function?

[std10093]

You could include this 4 files in .h file and then include only one file .h
But this 4 lines seem to be no problem at all to me

[jimblumberg]

You need to pass the HANDLE to the functions that need it as a parameter.

Jim

[JayCee++]

If I put those 4 lines in a funtion called colour and pass front and back colours to it I could then use it everywhere with just one line; would system (CLS) work by itself in a function?

[std10093]

We do not include libraries into a function

[jimblumberg]

First why are you using system() at all. You already seem to be aware of the Windows API, so use it to properly clear the screen. See this link for more information. MSDN Clearing the Screen, use example two.

To use system() in any function you must include the proper include file cstdlib/stdlib.h in the file that contains this call.


Jim

[JayCee++]

Hi Jim,

it isn't just the system call to clear the screen but also I sometimes want to change the text colour which is why I use this, I have looked at the method you suggest and it is quite possible to put that in my program with no bother but I would still need the other one to uses SetTextAttribute wouldn't I?

I have been using the sys call but haven't got the cstdlib in my include files, from what you say I should think it shouldn't be working should it?

Sorry if this isn't going in as easily as it should but I am getting on a bit!!!

[jimblumberg]

The include file for system() may be included by windows.h, however it is considered a bad practice to rely on some other file including a standard include file for you. Always include the proper include file for the functions you are going to use.

but I would still need the other one to uses SetTextAttribute wouldn't I?

What other one? To use SetTextAttribute all you should need to include is windows.h.

Jim