What is happening with this code??

[Dogged]

I have this function that is meant to draw the highscores using a class called fileHandler which manages the highscore.txt file.

For some reason which I cannot see right now, when I step through the code I notice that the values for scoreList (which contain a structure called scoreData that consist of a string and a int for the score) are changing in the introduction for the for loop.

It goes from having a empty string and a integer holding 6 to a really small integer, like when a value is uninitialized, and a string with a bad pointer.

How is this being altered?????

void menu::drawScoreBoard(void)
{
///////////////////////////DRAW THE SCORE BOARD HERE//////////////////////////////////////////////////////////////////
    fileHandler scoreFile;
    std::vector <dataType::scoreData *> scoreList;
    std::string temp;
    int count = 1;

    if (scoreFile.getScore(&scoreList))
    {
        for (std::vector<dataType::scoreData *>::iterator it = scoreList.begin(); it < scoreList.end(); it++) //error here
        {
            temp = drawArea->IntToStr(count) + ") " + (*it)->initials + drawArea->IntToStr((*it)->score);
            drawArea->drawMessage(temp, scoreBoardPos.x, scoreBoardPos.y +count);
            count++;
        }
    }
}

[Salem]

    std::vector <dataType::scoreData *> scoreList;
    std::string temp;
    int count = 1;
 
    if (scoreFile.getScore(&scoreList))

Is this just filling in a vector with a load of pointers to memory that no longer exists (say local vars in getScore()) ?

Forget the pointers and trying to make it "efficient", and get it working by making a regular copy of the data.

[rags_to_riches]

Not to mention, if you're populating a vector, then the method name getScore() is confusing, because it's actually getting a list of scores, as the variable itself states clearly. Better to make that method getScores(std::vector<dataType::scoreData *> &scoreList) or getScoreList(std:vectordataType::scoreData *> &scoreList)

[Dogged]

I forgot the pointers like you said and it worked like a treat, thanks!

@rags_to_riches Noted, I have been slightly changing functions around without changing the name.

Thanks for the help!