Thread: Creating a folder with subfolders

So I have been using mkdir() to make my folders, only problem is that it doesn't create subfolders.

I.e. if mkdir("c:\a\b\c\d") but if c:\a\b\c are not present it doesn't make d folder.

To circumvent this i made this code, it looks fine and runs fine but crashes at the end. No idea why though :/ Might have missed something silly.

Thanks!

Code:

#include <iostream>
#include<fstream>
#include <direct.h>
using namespace std;

int main()
{

    char file_loc[140] = "C:/a/b/c/d/";
    char tempfile_loc[140] = {' '};

    int counter = 0;

    do
    {
        while( file_loc[counter] != '/' )
        {
            tempfile_loc[counter] = file_loc[counter];
            counter++;
        }

        tempfile_loc[counter] = file_loc[counter];
        counter++;

        cout << tempfile_loc << endl;
        mkdir(tempfile_loc); // problem only makes one folder at a time



    } while (file_loc[counter+1] != ' ' );

    return 0;
}

Your problem is that your code will keep looping past the zero terminator at the end of the string (the inner loop looks for a '/' and the outer loop looks for a ' ').

The net effect is that, eventually, your code is reading data past the end of file_loc (undefined behaviour) and writing it past the end of tempfile_loc (also undefined behaviour).

So your main error is comparing to space (for some reason) instead of '\0'.

counter is a bad name, mostly because it isn't a counter, it's an index. I'd suggest i.

This is a little strange

Code:

char tempfile_loc[140] = {' '};

It's usually written like this

Code:

char tempfile_loc[140] = " ";

Although I don't see the purpose of it. Neither of the above is going to init the array to spaces, for instance, which seems to be what you've assumed.

Also, it's usual to employ the string handling functions from the C library (if not the C++ string class). You may find strchr() useful.