Thread: Counting vowels in a string - invalid identifier

This is just a small fragment of my code so I didn't include all the vowels.

Code:

    string response;
    int array [5]= {0, 0, 0, 0, 0};


    cout << "enter a string of text\n" << endl;
    cin >> response;
 
      for(int i=0;i<strlen(response);i++)
    {
    if response == 'A'        //invalid identifier
        array[i]++;
    if response == 'E'     //invalid identifier
        array[i]++;
       }

I am getting the error that "response" is not a valid identifier? When I'm trying to check the characters in the string for either A or E and increment the count in the appropriate area of the array...

The condition of an if needs to be in parentheses.

I now have a working code.

Problem is when I output the incremented array (its supposed to increment) I'm being told that all the vowels have occured 0 times when this is not the case?

I've tried changing the array[i] to a number i.e. [1] instead of [i]

What is your current code?

I've tried changing the array[ i] to a number i.e. [1] instead of [ i]

That's actually a correct change. Just remember to use 0 for A, 1 for E, etc. Also, are you forgetting to count lowercase vowels?

Originally Posted by CornedBee

That's actually a correct change. Just remember to use 0 for A, 1 for E, etc. Also, are you forgetting to count lowercase vowels?

I am coding it so that it accepts lower case vowels only at the moment, I can change that later but its good to go for the moment.


@laserlight, here is my current code:

Code:

#include <iostream>
#include <string> 

int main()
{
string response;
int array [5]= {0, 0, 0, 0, 0};


cout << "enter a string of text\n" << endl;
cin >> response;

  for(int i=0;i<response.length();i++)
{
if (response == "a")        //invalid identifier
    array[0]++;
if (response == "e")     //invalid identifier
    array[1]++;
}
cout << array[1];   //doing this as a test but get 0 no matter how many e's I type in.

return 0;
}

strlen(response) shouldn't even compile. You were told to use response.length().

Also, I don't see a place where you output the results.

Character literals are written with single quotes. Double quotes are string literals, which you can't meaningfully compare to single characters. That this compiles at all points out that you have another mistake, namely in your if conditions, you compare the entire input string against the single character string. Which obviously won't work.

if (response[i] == 'a')