Thread: Age Check Program

Remove the semi-colon between the closing bracket and the opening curly bracket. The semi-colon makes the if only apply to an empty statement block.

Next, read up about what == does versus what = does.

Lastly, learn about global variables versus local variables, and why you should learn to use local variables instead of globals wherever possible.

That should have it all sorted out for you.

Thank you very much i tweaked it a bit. I looked up the == and =. That made a big difference.., the program is working fine now.
Here is the tweaked program.

Code:

#include <iostream>
    using namespace::std;
    int a;
    int b;
    int c;
    
    int main()
    
{
    cout<<" Age Check" <<endl;
    cout << "Enter the current year "<< "\n";
    cin>>a;
    cout << " Enter the year born" << "\n" ;
    cin>>b;
    cout <<" If born on January press 1 if born after press 0"<<"\n";
    cin>>c;
    
    if  (c == 1) 
    {
    int result2 (2011- a);
    cout <<" You are : " <<result2<<"\n";
    cin>>result2;
    getchar(),getchar(),getchar(),getchar();

    }

    else if (c == 0)
    {
    int result = ( a - b );
    cout << " You are : " <<result<<endl;
    cin>>result;
    getchar(),getchar(),getchar(),getchar();
    return 0;
    }
    
    
    
    }

A couple of suggestions.

Declaring `a`, `b` and `c` outside of `main()`, outside of any functions, for that matter, makes them what is called global variables. This means that they are accessible everywhere, in any function. That might seem like a good thing at first, and can sometimes be useful, but is generally discouraged in programs of any significant complexity, except in special cases, like definition of constants and certain development patterns. Reason being that, if these variables can be changed from several functions it becomes hard to debug the program and it can make it hard to argue about the global state of the program. In this case, move them inside of `main()` and you'll be OK.

Your `using` statement is incorrect. At least I think it is, or it's a form I've never seen before. It should be `using namespace std;`, otherwise you're declaring that you're using name `std` from namespace `namespace`.

You can declare multiple variables of the same type on the same line, like `int a, b, c;` instead of one per line. This is OK for simple types, but can lead to subtle errors. Consider `int* a, b, c;`. This looks like declaring three `pointers-to-int` but is, in fact, a declaration of `pointer-to-int` `a` and `int`s `b` and `c` due to `*` decorator binding to the right.

Chaining `getchar()` like that is likewise unnecessary, usually one is enough, and none are needed if you'll be executing from the console.

Not only are the multiple calls to getchar() unneeded, but they could potentially cause problems. You should not mix iostream and stdio functions. Use std::cin.get() instead.

Indentation can be improved, as well.