Thread: A beginner's code, need suggestion

Hi,

I am new to programming and I just want to know if the code written below is good, average or bad as a professional programmer.

Thanks in advance.

Regards,
Sumit

Code:

#include <iostream>

using namespace std;

int main()
{
    int a,rem, rev = 0;

    cout<<"Please enter a number: ";
    do
    {
        cin>>a;
        if(a>10)
            break;
        cout<<"Please enter another number higher than 10: ";
    } while (a<10);

    if(a>=10)
    {
        while (a!=0)
        {
            rem = a % 10;
            rev = rev*10 + rem;
            a = a/10;
        }
        cout<<endl<<endl<<"Reverse is "<<rev<<endl<<endl;
    }
}

Well I won't give you a grade or anything but ...

unless a could change somewhere after the input loop the if block following it is unnecessary, and

a professional would worry about what happens if the input would fail.

First of all, thanks for the help.

Well, I put the if block specifically there to test a situation where a user tries to input numbers below 10 many times (probably just for fun or whatever)

And I didn't understand the input failure part. Could you elaborate.

Thanks

Originally Posted by sumitsatsangi

First of all, thanks for the help.

Well, I put the if block specifically there to test a situation where a user tries to input numbers below 10 many times (probably just for fun or whatever)

And I didn't understand the input failure part. Could you elaborate.

Thanks

Just so that we're talking about the same code, I mean the if block that starts on line 18. There is no need to check that because of the input loop condition.

And what I mean is basically what should happen if the user types something that is nothing like a number. For example 1234 can be converted to a number by the cin object but onetwothreefour cannot.

couldn't the while portion be put behind the first IF statement, leaving the second if block out completely? (to do the same thing I mean)

Sry... also just learning this stuff, so I was wondering.

Like this:

Code:

    do
    {
        cin>>a;
        if(a>=10)
        {
			while (a!=0)
			{
				rem = a % 10;
				rev = rev*10 + rem;
				a = a/10;
			}
			cout<<endl<<endl<<"Reverse is "<<rev<<endl<<endl;
			break;
        }
        else
        {
        	cout<<"Please enter another number higher than 10: ";
        }
    } while (a<10);

Thanks nGAGE... looks better... BTW, none of my codes are my homework... I took home tuition for C++ in order to understand programming concepts. Now they are over and I am working on my own, exploring new programs (ofcourse of middle levels) and hoping to enhance my learning curve.

I'm only a beginner, so don't take my suggestion as professional feedback or something. It's been only a week since i've started reading the tutorials on this site, but I gladly try to look at things I didn't write and rewrite/rearrange it, if possible. Guess it helps with the learning better.
At this point, I've rewritten my own little (learning-)project like 4 times, every time in a different way, applying new things learned. Probably all not making much programming sense :P
It's pretty hard to understand good programming practice and logic at the beginning, or when to apply what methods. At least, for me.

Anyways,... Wish you enjoyment with your further projects.