Thread: Changing from basic to class structure

Basically I did some code for betting on horses here
here the header with the function prototypes

Code:

int assignOdds (int horse) ; // function to assign odds
int whichHorseToBetOn (void) ; // function to ask which horse to bet on
int getAmount (void) ;  // function to ask how much to bet
int runRace (void) ; // function to run the race

Main file

Code:

//Horse Betting
#include <iostream>
#include <ctime>
#include <cstdlib>
#include "betting.h"

using namespace std ;

int Cash = 100;   // starting cash
int const NUMBEROFHORSES = 8 ;  
int Bet = 0 ;  // how much have they bet
int horseWon = 0 ; 
int x =0 ;  
int odds[7] ; // array which holds each horses odds
int tempOdds = 0 ; 
int winner = 0; 
int thisBet = 0; // holds horse bet on
int Amount = 0; //. holds amount bet this race

int main()
	{

	while (Cash > 0)	
		{
		cout << "You have " << Cash << " to spend. " ;  

		for(x=0	;	x<NUMBEROFHORSES	;	x++)	//loop asign and display odds
		{
	odds[x]= assignOdds(x) ;
	cout << "Horse " << x+1 << " Odds are " << odds[x] <<"/1 " ;
		}																				
	cout << "Which Horse do you want to bet on -  " ;   
	Bet = whichHorseToBetOn() ;						
thisBet=getAmount();								
	cout << endl ;
winner=runRace();// selects winning horse randomly with runRace() function

	if (winner+1 == Bet) {							
		Cash = Cash+(thisBet*odds[winner])+thisBet ;	// If you have picked the winner then calculate earnings
	}
}

}



int assignOdds (int horse) // assign random odds to horse
{
	tempOdds=(rand()%10)+1;
	return tempOdds ;
}

int whichHorseToBetOn ()	
{
	cin >> Bet ;
	return Bet ;
}

int getAmount ()	
{
	cout << "How much do you want to bet? 
 
 You currently have " << Cash << " to spend -  ";
	cin >> Amount ;
	Cash=Cash-Amount ;
	return Amount ;
}

int runRace () // calculates randomnly which horse has won the race and displays it on screen
{
	horseWon=(rand()%8);
	cout << "Horse " << horseWon+1 << " has won the race! 
"  ;

	cout << endl << endl << endl ;
	return horseWon;
}

Now its a fairly simple program but what I want to do now is to do it with class's
So i'm writing this off the top of my head
race.h file

Code:

class race:
{
       public:
          race();
         virtual ~race();
       int assignodds(int horse);
      int whichhorsetobeton(void);
      int getAmount(void);
      int RunRace(void);

      private:


}

then my race.cpp would be

Code:

race::race
{

}
race::~race()
{
}

int race::assignOdds(int horse)
{
    tempOdds=(rand()%10)+1;
    return tempodds;
}

int race::getAmount()
{
cout << "How much do you want to bet? 
 You currently have " << Cash << " to spend -  ";
	cin >> Amount ;
	Cash=Cash-Amount ;
	return Amount ;
}

int race::whichhorsetobeton()
{
cin >> Bet ;
	return Bet ;
}

int race::runRace()
{
	horseWon=(rand()%8);
	cout << "Horse " << horseWon+1 << " has won the race! "  ;
	cout << endl << endl << endl ;
	return horseWon;
}

Haven't time to write a main.cpp to call all that in,so is any of it right?
I'm pretty sure the race.cpp is wrong,I think I have to put in setters and getters in there but I'm pretty iffy on those

Code:

class race:
{
       public:
          race();
         virtual ~race();
       int assignodds(int horse);
      int whichhorsetobeton(void);
      int getAmount(void);
      int RunRace(void);
 
      private:
 
 
}

With syntax errors in tact....

Haven't time to write a main.cpp to call all that in,so is any of it right?

Define right. Are you required to write the race class? I don't like the design. It's a god object. I would fix it like this: take out all of the stuff related to gambling, and put that in a different class. In main, use the gambling object first. Then, run the race. Afterward, use the information from the race object to know who won the bet.

Well I'm meant to do is write a program using OOP principles and dynamic
memory allocation.I thought it would be easier to write the program first,then bring in classes and then use memort allocation.

So I started off it very basic,just trying to output my cash value in my main.cpp.I know I'm doing something very stupid below but I'm not sure.

Code:

#ifndef RACE_H
#define RACE_H

class race
{
    public:
        race();
        virtual ~race();
        int getCash();

    private:
    int Cash ;   // starting cash
};

#endif // RACE_H

Code:

#include "race.h"
#include <iostream>
#include <ctime>
#include <cstdlib>
using namespace std;
race::race()
{

    int Cash = 100;
}
race::~race()
{
    
}
int race::getCash()
{
    return Cash;
}

Code:

#include <iostream>
#include <ctime>
#include <cstdlib>
#include "race.h"

using namespace std;

int main()

	{
    race ob;
    ob.getCash();
cout << "You have " << Cash << " to spend. \n \n" ;
}

Fixed it
int cash = 100 should be just cash =100;
and my cout should read
cout << "You have " << ob.getCash() << " to spend. \n \n" ;
Silly mistakes really....can't wait to make some ore in the rest of the program

Originally Posted by King Mir

That's kinda backwards, especially with regards to classes. OOP is an approach to program design, so you should use it to design. Classes are tools to help your OOP programs easier to write.

Ya I know I'm just not that familiar with classes,I find it easier it just write the program in one big main even though that completely backwards.
Anyway I'm having problems with my for loop now
Orginally it was this

Code:

for(x=0	;	x<NUMBEROFHORSES	;	x++)	//loop asign and display odds
		{
	odds[x]= assignOdds(x) ;
	cout << "Horse " << x+1 << " Odds are " << odds[x] <<"/1 " ;
		}

and I tried changing it to this

Code:

for(ob.getx()=0	;ob.getx()<ob.getnumhorses();ob.getx()++)	
		{

		}

this is my current header and cpp file that goes with it.

Code:

#ifndef RACE_H
#define RACE_H


class race
{
    public:
        race();
        virtual ~race();
       int getCash();
       int getx();
       int getnumhorses();
    private:
    int Cash ;   // starting cash
    int numberofhorses ;  // total number of horses to bet on
    int x  ;  // used in "for" loop as a counter

};
#endif // RACE_H

Code:

#include "race.h"
#include <iostream>
#include <ctime>
#include <cstdlib>
using namespace std;
race::race()
{

    Cash = 100;
   // int tempOdds = 0 ;
     x =0 ;
     numberofhorses = 8 ;

}
race::~race()
{
    //dtor
}
int race::getCash()
{
    return Cash;
}
int race::getx()
{
    return x;
}
int race::getnumhorses()
{
    return numberofhorses;
}

I'm thinking the error had something to do with not being able to increment a function

I'm thinking the error had something to do with not being able to increment a function

That's a good guess, but doesn't your compiler give you an error message? It's better if you give us that information.

Anyway, think of how many times you need to get x. You could do a couple things. One is You could change a copy of x, which means call getx() once to get a value, and store it in a variable. Then use the variable. Although, I don't like that the for loops variable is a member of the race class for no reason.

Code:

for (int x = 0; x != ob.getnumhorses(); x++)

Isn't this the same thing?

Remember this also: design is important to have gotten right from the beginning. Of course, that's not possible,

It's completely possible. Especially important is design in nontrivial work.

Ack I give up,I just don't know enough about class's and setters and getters.Gonna try and re-write my orginal code using dynamic memory

Easily frustrated I guess
So on my orginal code if I were to replace the key word Cash with
int *ptr;
ptr = new int;
*ptr = 100;
so would replacing cash with *ptr work?