Structure and reading from a file

[acmarshall]

Hello all, I had to made a code to read from an input file using structures. The input file was information relating to a car dealership. I didn't post the input file, but I can if you need me to. I had to calculate the total revenue, the cars that have years greater than 2000, the cars that have prices under 5000, the cars that were black, and the cars that were toyotas and red. I am having trouble with the total revenue, the cars that are black, and the cars that are toyotas and red, other than that my program works fine. Can you help me please?

 
# include<cmath>
# include<iostream>
# include<iomanip>
# include<cstring>
# include<cctype>
# include<fstream>
# include<string>

usingnamespace std; 

int main()
{ifstream fin;
fin.open("fin.txt");

int cnt2000 = 0; 
int cnt5000 = 0; 
int cntcolor = 0; 
int cntcoma = 0; 
int sum = 0; 

struct car {
string id;
string make;
string model;
int year;
string color;
int purchase_month;
int purchase_day;
int purchase_year;
float cost;
int sold_month;
int sold_day;
int sold_year;
int sale;
int revenue;
}mycar;

cout << "ID " << "Make " << "Model " << "Year " << "Color " << "Purchased " << "Cost " << "Sold " << "Sale " << "Revenue " << endl; 

cout << "************************************************************************" << endl; 

while (fin)
{fin >> mycar.id >> mycar.make >> mycar.model >> mycar.year >> mycar.color >> mycar.purchase_month >> mycar.purchase_day; 

fin >> mycar.purchase_year >> mycar.cost >> mycar.sold_month >> mycar.sold_day >> mycar.sold_year >> mycar.sale; 

mycar.revenue = mycar.sale - mycar.cost; 

cout << mycar.id << " " << mycar.make << " " << mycar.model << " " << mycar.year << " " << mycar.color << " "; 

cout << mycar.purchase_month << "/" << mycar.purchase_day << "/" << mycar.purchase_year << " " << mycar.cost << " "; 

cout << mycar.sold_month << "/" << mycar.sold_day << "/" << mycar.sold_year << " " << mycar.sale << " " << mycar.revenue << endl; 

cout << endl; 

sum = ++mycar.revenue; 

if (mycar.year > 2000) 
{++cnt2000; }

if (mycar.cost < 5000) 
{++cnt5000; }

if (mycar.color == "black")
{ ++cntcolor; }

if (mycar.make == "toyota" && mycar.color == "red") {++cntcoma; }
};

　
cout << "Total Revenue = " << sum << endl; 
cout << "Year greater than 2000 = " << cnt2000 << endl; 
cout << "Cost less than 5000 = " << cnt5000 << endl; 
cout << "Blacks = " << cntcolor << endl; 
cout << "Toyota and Red = " << cntcoma << endl; 
　
system ("pause"); 

return 0; 
}

[Salem]

You should repost your code, only this time make sure you "paste as text" and not "paste as HTML".

Then perhaps we might see some decent indentation, and somewhat consistently coloured code.

The "wall of blue" really isn't helping that much.

[rags_to_riches]

Can you also tell us in detail what "having trouble" means in this quote?

I am having trouble with the total revenue, the cars that are black, and the cars that are toyotas and red, other than that my program works fine.

[acmarshall]

Sorry what I meant by "having trouble" is that when I run my program I don't get the results that I want. I don't know how to add all the revenues up correctly and I don't know how to search for a string correctly to output results. And as for the rest of my program I get when I intended its only these few things that aren't working. I posted a better version of my code below sorry for all the blue lol.

 

# include<cmath>
# include<iostream>
# include<iomanip>
# include<cstring>
# include<cctype>
# include<fstream>
# include<string>

usingnamespace std; 

int main()
{ifstream fin;
fin.open("fin.txt");
int cnt2000 = 0; 
int cnt5000 = 0; 
int cntcolor = 0; 
int cntcoma = 0; 
int sum = 0; 
struct car {
string id;
string make;
string model;
int year;
string color;
int purchase_month;
int purchase_day;
int purchase_year;
float cost;
int sold_month;
int sold_day;
int sold_year;
int sale;
int revenue;
}mycar;

cout << "ID " << "Make " << "Model " << "Year " << "Color " << "Purchased " << "Cost " << "Sold " << "Sale " << "Revenue " << endl; 

cout << "************************************************************************" << endl; 

while (fin)
{fin >> mycar.id >> mycar.make >> mycar.model >> mycar.year >> mycar.color >> mycar.purchase_month >> mycar.purchase_day; 

fin >> mycar.purchase_year >> mycar.cost >> mycar.sold_month >> mycar.sold_day >> mycar.sold_year >> mycar.sale; 

mycar.revenue = mycar.sale - mycar.cost; 

cout << mycar.id << " " << mycar.make << " " << mycar.model << " " << mycar.year << " " << mycar.color << " "; 

cout << mycar.purchase_month << "/" << mycar.purchase_day << "/" << mycar.purchase_year << " " << mycar.cost << " "; 

cout << mycar.sold_month << "/" << mycar.sold_day << "/" << mycar.sold_year << " " << mycar.sale << " " << mycar.revenue << endl; 

cout << endl;
 
sum = ++mycar.revenue; 
if (mycar.year > 2000) 
{++cnt2000; }

if (mycar.cost < 5000) 
{++cnt5000; }

if (mycar.color == "black")
{ ++cntcolor; }

if (mycar.make == "toyota" && mycar.color == "red") 
{++cntcoma; }
};
　
cout << "Total Revenue = " << sum << endl; 
cout << "Year greater than 2000 = " << cnt2000 << endl; 
cout << "Cost less than 5000 = " << cnt5000 << endl; 
cout << "Blacks = " << cntcolor << endl; 
cout << "Toyota and Red = " << cntcoma << endl; 
　
system ("pause"); 
return 0; 
}

[hk_mp5kpdw]

#1

sum = ++mycar.revenue;

That's probably not what you want.

---

#2

if (mycar.color == "black")
{ ++cntcolor; }
if (mycar.make == "toyota" && mycar.color == "red") 
{++cntcoma; }

The comparison is case sensitive. If your input file has "TOYOTA" or "Toyota" or "ToYoTa" then it isn't going to match "toyota" since they are considered different. It might help to see what's in the input file.

---

#3

while (fin)

This results in the same problem/bug as using eof to control a loop. Instead you should test the result of the read operation which would look like this:

while( fin >> mycar.id >> mycar.make >> mycar.model >> mycar.year >> mycar.color >> mycar.purchase_month >> mycar.purchase_day >> mycar.purchase_year >> mycar.cost >> mycar.sold_month >> mycar.sold_day >> mycar.sold_year >> mycar.sale )

That's a mouthful and so I'd recommend you overload the stream extraction operator (operator>>) if possible so you could reduce that to:

while( fin >> mycar )

[rags_to_riches]

What you would expect vs. what you are receiving would be helpful information.

sum = ++mycar.revenue;

That adds one to the value of mycar.revenue and sets the value of sum to that incremented value. Therefore, you need to rethink that logic. And that's pretty much all it is - thinking about the logic of that line.

I don't know how to search for a string correctly to output results

Where does that fit in with what you've posted, either in code or in the details you've provided? This looks to be a strict read the data in, do calculations, and output the results program.

[acmarshall]

Thank you! I just changed my program. I used sum = sum +mycar.revenue. And the first letters of my strings were capital. I can't believe it was that simple lol.