Thread: string-manipulating function

Search through the string. If you encounter a space-comma element, simply move every element after that one one step to the left.

Don't have much time to respond at the moment so I can't answer your question but I would like to point out a problem that I saw immediately with the function definition.

Code:

void formatline (char line [50]);

As you have it, the variable line is a character array. As such, when the code runs, a new variable line will be created local to the function formatline. This local variable will be manipulated in some way by the function. I am assuming you wish to call this function from some other piece of code and then use the modified string after calling the function. The problem with this, is that the function is going to modify the local copy of the character array and not the one that exists in whatever piece of code called the formatline function. After you have called the function, whatever variable you passed into the function is going to be the exact same thing as before the function call. You will probably need to change the function header like so:

Code:

void formatline( char* line );

With the variable line as a pointer, the changes to the character array you pass into the function will remain in effect after the function has completed. You will call this function exactly like you would your original version, i.e.:

Code:

char buffer[50];
...
...
...
formatline( buffer );

Anyway, if your intent wasn't to have this modified character array available after the function call, then ignore the above.

Code:

left shift by 1 if letter b

char line[30] = "happy birthday"
for(i = 0; i < strlen(line); i++)
{
  if(line[i] == 'b')
  {
     for(j = i; j < strlen(line); j++)
     line[j] = line[j + 1];
   }
}

right shift by 1 if letter 'a' and insert * where letter 'a' was

for(i = 0; i < strlen(line); i++)
{
  if(line[i] == 'a')
  {
     for(j = strlen(line); j < i; j--)
     {
        line[j + 1] = line[j];
     }
      line[i++] = '*';
   }
}

thanks elad!

the two for loops you posted - i modified the first one a little so it's fine now for "deleting" the space before a comma. but the second one:

Code:

for(c = 0; c < strlen(line); c++)
{
  if(line[c] == 'a')
  {
     for(j = strlen(line); j < c; j--)
     {
        line[j + 1] = line[j];
     }
      line[c++] = '*';
   }
}

just replaces 'a' with '*', it doesn't shift anything over..

it's probably in the second for loop header, where you say j<c, i think that prevents it from getting into that loop.. what should i change it to?..

actually no..!.. if 'a' is being replaced by '*' with that statement (line[c++]...) that should mean that it has been shifted over once (to the right).. but why does the output look exactly like the original string only with 'a' replaced..?.. i'm confused!..