sort with vector pointers

**thedodgeruk** · 10-23-2011

Code:

bool MySort(CModel* entity1 , CModel* entity2)
{
        return entity1->m_pDiffuseMap < entity2->m_pDiffuseMap;

}



std::sort (m_modelvector.begin(), m_modelvector.end(), MySort);

m_modelvector is
vector <CModel*> m_modelvector;

im getting these errors

: error C3867: 'CRenderManager::MySort': function call missing argument list; use '&CRenderManager::MySort' to create a pointer to member

: error C2780: 'void std::sort(_RanIt,_RanIt)' : expects 2 arguments - 3 provided

i know its some thing stupid , but just cant figure it out , any one help please?

**laserlight** · 10-23-2011

I'm guessing that you declared MySort as a member function of CModel. It may make more sense to declare it as a non-member function, or maybe a static member function. (And rename it, since it compares, not sorts.)

**adeyblue** · 10-23-2011

Hey look, the same answer you got yesterday. If you don't understand the response, perhaps you should ask for clarification rather than jumping from forum to forum hoping someone will answer it in simpler terms.

**thedodgeruk** · 10-23-2011

tryed making a it a static and got exact same thing

**laserlight** · 10-23-2011

Originally Posted by thedodgeruk

tryed making a it a static and got exact same thing

On the other hand, I tried making it a static member function and did not get the same thing:

Code:

#include <vector>
#include <algorithm>

class CModel
{
public:
    CModel() : m_pDiffuseMap(0) {}

    static bool MySort(CModel* entity1 , CModel* entity2)
    {
        return entity1->m_pDiffuseMap < entity2->m_pDiffuseMap;
    }
private:
    int m_pDiffuseMap;
};

int main()
{
    std::vector<CModel*> m_modelvector(100);
    std::sort(m_modelvector.begin(), m_modelvector.end(), CModel::MySort);
}

**Salem** · 10-23-2011

sort - C++ Reference

**Elysia** · 10-23-2011

Laser, are you sure there should not be a & before the function in your example?
As in,
&CModel::MySort
instead of
CModel::MySort

**King Mir** · 10-23-2011

Originally Posted by Elysia

Laser, are you sure there should not be a & before the function in your example?
As in,
&CModel::MySort
instead of
CModel::MySort

It's optional. You don't need & when taking the address of a function.

**Elysia** · 10-23-2011

But it's different with a member function.
EDIT: I suppose it's different with static member functions. VC compiles without the ampersand.

**thedodgeruk** · 10-23-2011

cheers , it looks like is the same thing as templates , dont seam to like it when you put them in the cpp file

**Elysia** · 10-23-2011

You should not put templates in .cpp files. Write them inline and store them in headers.

**iMalc** · 10-23-2011

Originally Posted by thedodgeruk

cheers , it looks like is the same thing as templates , dont seam to like it when you put them in the cpp file

One can put class static methods in a cpp file just fine.
You must have gotten the syntax wrong.
Post the code you tried and we'll show you what you did wrong.

Thread: sort with vector pointers

Thread Tools

Search Thread

Display

sort with vector pointers

Similar Threads

Sort a std::vector<int>

sort a vector

Sort 2D Vector

sort a vector

vector sort