Need a little bit of help!

**Sephyx** · 10-15-2011

The program is pretty much done. It's a program to split an input such as 20110102 into 01/02/2011. I already have the loop in place, but for some reason when I output the program it gives me huge numbers. Please tell me what's wrong in my void function. Thank you.

Code:

#include <iostream>
#include <iomanip>
using namespace std;




void date (int fulldate, int month, int day, int year)
{


year = (fulldate/100/100);
month = (fulldate0);
day = ((fulldate/100)0);


}




int main()
{


rerun:
int fulldate, month, day, year;
char a;


cout << "Enter a long integer of the form yyymmdd: "<< endl;
cin >> fulldate;


cout << "The date is " << month << "/" << day << "/" << year <<endl;


cout << "Would you like to try again? [y/n]" << endl;
cin >> a;
    if (a == 'y' || a == 'Y')
        goto rerun;
        
    else
        return 0;
}

**laserlight** · 10-15-2011

A few things:

You should properly indent your code.
Replace your label and goto with a loop construct, e.g., a do while loop.
It probably makes more sense to read the input as a string, not as an integer.

spaghetticode · 10-15-2011

You actually never use your function. You just cout your uninitialised variables month, day and year.

**Sephyx** · 10-15-2011

Oh edit, I actually solved it by putting & on the ints in the void function as well as adding the date(), ty.

Code:


#include <iostream>
#include <iomanip>
using namespace std;




void date (int& month, int& day, int& year, int& fulldate)
{


year = (fulldate/10000);
day = (fulldate0);
month = ((fulldate/100)0);




return;


}




int main()
{


rerun:
int month, day, year, fulldate;
char a;


cout << "Enter a long integer of the form yyyymmdd: "<< endl;
cin >> fulldate;


date (month, day, year, fulldate);
cout << "The date is " << month << "/" << day << "/" << year <<endl;


cout << "Would you like to try again? [y/n]" << endl;
cin >> a;
	if (a == 'y' || a == 'Y')
		goto rerun;
		
	else
		return 0;
}

Thread: Need a little bit of help!

Thread Tools

Search Thread

Display

Need a little bit of help!