Infix to postfix stack class problem
I am implementing a stack class to convert infix expressions to postfix expressions.
Program runs when I enter : (A*(B+C))
for example and gives me the correct ABC+*
But when I randomly entered (5+3)*3, I got a seg fault.
I suspect it's something in the actual algorithm.
Any ideas?
Here is the relevant code.
Edit: Code removed
Any ideas or pointers would be appreciated
Last edited by stefanyco; 10-05-2011 at 03:17 PM.
Implement your algorithm using std::stack so that you can be more certain that you did not mess up the stack implementation.
Oh, and this function really should not be part of your stack class template.
Look up a C++ Reference and learn How To Ask Questions The Smart WayOriginally Posted by Bjarne Stroustrup (2000-10-14)
I agree, but pulling this out of main got it working somehow. And i am not confident with std::stack and how to implement using that so for now i just need to figure out why * after ) causes seg fault. Would it most likely be stack issues? Or my algorithm?
Test the stack separately...(but substituting it for std::stack or std::vector for a while would be better)
My guess would be... that your implementation does not handle problems carefully. And due to some mistake in implementing the algorithm, you do something problematic.
Last edited by manasij7479; 10-05-2011 at 01:01 AM.
That's ironic though. At the moment you have two suspects: is your implementation of the conversion algorithm at fault, or is your stack implementation to blame? If you use std::stack, you only have one suspect. Certainly, it could be the case that you used the stack incorrectly, but at least it is still the same suspect code.
Besides, conceptually the use of a stack is trivial: you just need to know the operations to push, to pop, to observe the top element, and to check if the stack is empty.
Use a debugger. Place breakpoints and step through until you reach the seg fault. Then, you know that the code somewhere before that breakpoint has a bug.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
Ah, I'll use a debugger. I somehow only thought debuggers were for assembly code. Haha.
And i have implemented a normal basic stack this way successfully before, that's why i suspected its the algorithm. But youre right. Ill just assume its both and test everything.
Thank you.
