Hi, I am having a problem with else not being linked to if.

**iGuardian** · 09-21-2011

I am doing a homework assignment where we have to have the user input a year and determine if it is a leap year or not. When i compile, I am have problems with "else" not being linked to "if". Am i writing a portion wrong, or what could it be. Any help is appreciated.

Code:

#include <iostream>

using namespace std;


int main()
{
    int entered_year, leap_year;


    cout << "Welcome to the Leap Year program." << endl;
    cout << endl;


    cout << "Please enter the year you wish to check if it is a leap year: ";
    cin >> entered_year;
    cout << endl;


    cout << "Please wait while we check if ";
    cout << entered_year;
    cout << " is a leap year..." << endl;


        {


        if ( entered_year % 4 == 0 )
        cout << entered_year;
        cout << " is a leap year." << endl;


            {


            if ( entered_year % 100 == 0 )
            cout << entered_year;
            cout << " is not a leap year.";


                {


                if ( entered_year % 400 == 0)
                cout << entered_year;
                cout << " is a leap year.";
                
                
                else
                cout << entered_year;
                cout << " is not a leap year." << endl;


                }


            else
            cout << entered_year;
            cout << "is a leap year." << endl;


            }


        else
        cout << entered_year;
        cout << " is not a leap year." << endl;


        }


    return 0;
}

**AndrewHunter** · 09-21-2011

It is because your opening and closing brackets are not matching up. Take a look at How to place braces and parentheses and Lesson 2: If statements. That will clear up your errors.

**iGuardian** · 09-21-2011

When you say my opening and closing brackets, is it

{

if ( entered_year % 100 == 0 )

**Shawn Belcher** · 09-21-2011

Read the if lesson he linked to, it will show your mistake.

**laserlight** · 09-21-2011

Yes, the brace should come after, not before the if clause.

**AndrewHunter** · 09-21-2011

No, something like this:

Code:

if(some condition)
{
     some stuff
     some more stuff
}
else if(some other condition)
{
     some stuff
     some more stuff
}
else
{
     some stuff
     some more stuff
}

**Shawn Belcher** · 09-21-2011

Code:

if { (x=y)


}

like that
you need the

Code:

{}

for each if and eles

**AndrewHunter** · 09-21-2011

Originally Posted by Shawn Belcher

Code:

if { (x=y)


}

like that
you need the

Code:

{}

for each if and eles

Your opening bracket needs to move to after the conditional statement.

**iGuardian** · 09-21-2011

Code:

#include <iostream>


using namespace std;


int main()
{
    int Year;


    cout << "Welcome to the Leap Year program." << endl;
    cout << endl;


    cout << "Please enter the year you wish to check if it is a leap year: ";
    cin >> Year;
    cout << endl;


    cout << "Please wait while we check if ";
    cout << Year;
    cout << " is a leap year..." << endl;


        {


            if ( Year % 4 == 0 )
            {
            cout << Year;
            cout << " is a leap year." << endl;




                if ( Year % 100 == 0 )
                {
                cout << Year;
                cout << " is not a leap year." << endl;




                    if ( Year % 400 == 0)
                    {
                    cout << Year;
                    cout << " is a leap year." << endl;


                    }
                    else
                    cout << Year;
                    cout << " is not a leap year." << endl;




                }
                else
                cout << Year;
                cout << " is a leap year." << endl;


            }
            else
            cout << Year;
            cout << " is not a leap year." << endl;


        }


    return 0;


}

It now compiles, but now when I run it, it gives me 3 answers, 2 of which are correct, 1 of which is not. I attempted to input "else if" into the code, then it would not work.

**laserlight** · 09-21-2011

Be careful when you fail to use braces.

**iGuardian** · 09-21-2011

Am i at least on the right track?

**laserlight** · 09-21-2011

Yes. Here's a hint. I would format this:

Code:

if ( Year % 400 == 0)
{
cout << Year;
cout << " is a leap year." << endl;


}
else
cout << Year;
cout << " is not a leap year." << endl;

as:

Code:

if ( Year % 400 == 0)
{
    cout << Year;
    cout << " is a leap year." << endl;
}
else
    cout << Year;
cout << " is not a leap year." << endl;

and even write it as:

Code:

if ( Year % 400 == 0)
{
    cout << Year;
    cout << " is a leap year." << endl;
}
else
{
    cout << Year;
}
cout << " is not a leap year." << endl;

Now can you spot the mistake?

**AndrewHunter** · 09-21-2011

It is because you are still not matching up your braces. Try this:

Code:

#include <iostream>

int main(void)
{
    using namespace std;
    
    int Year;

    cout << "Welcome to the Leap Year program." << endl;
    cout << endl;

    cout << "Please enter the year you wish to check if it is a leap year: ";
    cin >> Year;
    cout << endl;

    cout << "Please wait while we check if ";
    cout << Year;
    cout << " is a leap year..." << endl;

    if ( Year % 4 == 0 )
    {
	cout << Year;
	cout << " is a leap year." << endl;
    }
    else if( Year % 100 == 0 )
    {
	cout << Year;
	cout << " is not a leap year." << endl;
    }
    else if ( Year % 400 == 0)
    {
	cout << Year;
	cout << " is a leap year." << endl;
    }
    else
    {
	cout << Year;
	cout << " is not a leap year." << endl;
    }
    return 0;
}

EDIT:OOPs it appears when I was fixing your formatting Laser was leading you down a path. My bad Laser.

**iGuardian** · 09-21-2011

Oh, I understand. So should i simplify how I go about oragnizing and indenting my code to spot those mistakes easier? Sorry, I'm just barely starting coding.

**AndrewHunter** · 09-21-2011

Originally Posted by iGuardian

Oh, I understand. So should i simplify how I go about oragnizing and indenting my code to spot those mistakes easier? Sorry, I'm just barely starting coding.

Yes, it makes it much easier for you to spot your mistakes. Take a look at the link I gave you in post #2 about indentation.

Thread: Hi, I am having a problem with else not being linked to if.

Thread Tools

Search Thread

Display

Hi, I am having a problem with else not being linked to if.

Similar Threads

Linked List Problem

Linked list problem

Linked List of Linked list of linked list : problem with a condtion

linked list....problem

syntax linked list problem & struct problem