Thread: Sales department salary range generator

I am writing this program for my class and am having a problem getting my array to post to the proper ranges. I've been staring at it for hours. Can anyone offer a hint or tip?

Code:

//headers 
#include <cstdlib> 
#include <iostream> 
#include <conio.h> 
 
using namespace std; 
 
//Start of main 
int main() 
{ 
     
//Array chart initilization 
int salesArray[9]  = {0}; 
 
//variables and initialization 
int salary = 0; 
int grossSales = 0; 
int commission = 0; 
 
 
 
//Program introduction and instruction 
cout << "Department: Sales" << endl; 
cout << "Salary Range List Generator" << endl; 
cout << "--------------------------------------" << endl; 
cout << "Directions: "; 
cout << "This program will allow you to enter gross sales for each employee." << endl; 
cout << "Once you have finished entering their sales press -1 for a compiled list of ranges" << endl << endl; 
cout << "Gross Sales (or -1): "; 
cin >> grossSales; 
cout << endl; 
 
// while loop to update salary array chart 
 
while (grossSales != -1) 
{ 
       
      salary = 200 + commission; 
      commission = grossSales * .09; 
       
      if (salary < 200)  
      cout << "invalid entry" << endl; 
       
      else if (salary >= 200 && salary <= 299) 
      salesArray[0]++; 
       
      else if (salary >= 300 && salary <= 399) 
      salesArray[1]++; 
       
      else if (salary >= 400 && salary <= 499) 
      salesArray[2]++; 
       
      else if (salary >= 500 && salary <= 599) 
      salesArray[3]++; 
       
      else if (salary >= 600 && salary <= 699) 
      salesArray[4]++; 
       
      else if (salary >= 700 && salary <= 799) 
      salesArray[5]++; 
       
      else if (salary >= 800 && salary <= 899) 
      salesArray[6]++; 
       
      else if (salary >= 900 && salary <= 999) 
      salesArray[7]++; 
       
      else salesArray[8]++; 
 
      cout << "Enter Gross Sales (or press -1):"; 
      cin >> grossSales; 
      cout << endl; 
      }//end while 
       
      //salary range list generator 
      cout << "------------------------------------" << endl; 
      cout << "Salary ranges are listed below: " << endl; 
      cout << "------------------------------------" << endl; 
      cout << "$200-299: " << salesArray[0] << endl; 
      cout << "$300-399: " << salesArray[1] << endl; 
      cout << "$400-499: " << salesArray[2] << endl; 
      cout << "$500-599: " << salesArray[3] << endl; 
      cout << "$600-699: " << salesArray[4] << endl; 
      cout << "$700-799: " << salesArray[5] << endl; 
      cout << "$800-899: " << salesArray[6] << endl; 
      cout << "$900-999: " << salesArray[7] << endl; 
      cout << "$1000 +: " << salesArray[8] << endl; 
      cout << "End of List " << endl; 
       
      getch(); 
      return 0; 
       
      }//end main

What numbers do you type in?

Also, swap these two lines over, otherwise salary isn't what you think.
salary = 200 + commission;
commission = grossSales * .09;

Well even 1000 * .09 is only 90, which doesn't get you out of the 200 to 299 band.

Try bigger numbers, or a different scale factor.

I changed the code to vector and changed a couple of arbitrary things. The final product works well.

Code:

//headers
#include <cstdlib>
#include <iostream>
#include <conio.h>
#include <vector>

using namespace std;

//Start of main
int main()
{
    
//Array chart initilization
vector <int> salesVector(9);

//variables and initialization
int salary = 0;
int grossSales = 0;
int commission = 0;



//Program introduction and instruction
cout << "Department: Sales" << endl;
cout << "Salary Range List Generator" << endl;
cout << "--------------------------------------" << endl;
cout << "Directions: ";
cout << "This program will allow you to enter gross sales for each employee." << endl;
cout << "Once you have finished entering their sales press -1 for a compiled list of ranges" << endl << endl;
cout << "Gross Sales (or -1): ";
cin >> grossSales;
cout << endl;

// while loop to update salary array chart

while (grossSales != -1)
{
      commission = (int) (grossSales * .09);
      salary = 200 + commission;
      
      if (salary < 200) 
      cout << "invalid entry" << endl;
      
      else if (salary >= 200 && salary <= 299)
      salesVector[0]++;
      
      else if (salary >= 300 && salary <= 399)
      salesVector[1]++;
      
      else if (salary >= 400 && salary <= 499)
      salesVector[2]++;
      
      else if (salary >= 500 && salary <= 599)
      salesVector[3]++;
      
      else if (salary >= 600 && salary <= 699)
      salesVector[4]++;
      
      else if (salary >= 700 && salary <= 799)
      salesVector[5]++;
      
      else if (salary >= 800 && salary <= 899)
      salesVector[6]++;
      
      else if (salary >= 900 && salary <= 999)
      salesVector[7]++;
      
      else salesVector[8]++;

      cout << "Enter Gross Sales (or press -1):";
      cin >> grossSales;
      cout << endl;
      }//end while
      
      //salary range list generator
      cout << "------------------------------------" << endl;
      cout << "Salary ranges are listed below: " << endl;
      cout << "------------------------------------" << endl <<endl;
      cout << "$200-299: " << salesVector[0] << endl;
       cout << "------------------------------------" << endl;
      cout << "$300-399: " << salesVector[1] << endl;
       cout << "------------------------------------" << endl;
      cout << "$400-499: " << salesVector[2] << endl;
       cout << "------------------------------------" << endl;
      cout << "$500-599: " << salesVector[3] << endl;
       cout << "------------------------------------" << endl;
      cout << "$600-699: " << salesVector[4] << endl;
       cout << "------------------------------------" << endl;
      cout << "$700-799: " << salesVector[5] << endl;
       cout << "------------------------------------" << endl;
      cout << "$800-899: " << salesVector[6] << endl;
       cout << "------------------------------------" << endl;
      cout << "$900-999: " << salesVector[7] << endl;
       cout << "------------------------------------" << endl;
      cout << "$1000 + : " << salesVector[8] << endl;
       cout << "------------------------------------" << endl;
      cout << "End of List. Thank you! " << endl;
      
      getch();
      return 0;
      
      }//end main

Here we go again...

All of this...

Code:

     if (salary < 200)  
      cout << "invalid entry" << endl; 
       
      else if (salary >= 200 && salary <= 299) 
      salesArray[0]++; 
       
      else if (salary >= 300 && salary <= 399) 
      salesArray[1]++; 
       
      else if (salary >= 400 && salary <= 499) 
      salesArray[2]++; 
       
      else if (salary >= 500 && salary <= 599) 
      salesArray[3]++; 
       
      else if (salary >= 600 && salary <= 699) 
      salesArray[4]++; 
       
      else if (salary >= 700 && salary <= 799) 
      salesArray[5]++; 
       
      else if (salary >= 800 && salary <= 899) 
      salesArray[6]++; 
       
      else if (salary >= 900 && salary <= 999) 
      salesArray[7]++; 
       
      else salesArray[8]++;

... can be replaced with....

Code:

    if (salary < 200)
      cout << "invalid";
    if (salary > 999)
      salary =  1000;

   salesvector[(salary / 100) - 2]++;

Originally Posted by CommonTater

All of this can be replaced with....

Note that CommonTater's example gives the general idea. You should check to see if it is correct instead of using it blindly.

Originally Posted by CommonTater

In fact anyone who would use code from other sources (especailly a stranger on the internet) without vetting and testing is just begging for disaster.

Especially your code......

Code:

//headers 
#include <cstdlib>    // unnecessary
#include <iostream> 
#include <conio.h>    // unnecessary

Please don't include headers blindly. You're not using <cstdlib> and neither should you in a C++ program, and <conio.h> would have gone the way of the dodo if not for the instructors who consistently fail to keep themselves and their tools up-to-date. If you want to keep the console open just use `cin.get();`.