Thread: Help with strchr function

"= count" is not the same as "adding one".

EDIT: OIC, you're actually trying to count all the a, all the b, at one time. I guess that would work, although you appear to be starting at a weird place (shouldn't you always start at [0]?)

Also, printing might be odd as Salem points out below.

So what answers ARE you getting?

I can help by reposting your code with some decent indentation.

Code:

int main()
{
  char text[50];
  char *searchPtr;
  char character[26] = { '\0' };
  int count = 0;
  int i, j;

  cout << "Enter strings: \n\n";

  while (cin.getline(text, 50)) {
    for (i = 0; text[i] != '\0'; i++) {
      text[i] = tolower(text[i]);
    }
    for (i = 0; i <= 25; i++) {
      for (j = 0, count = 0; j <= 50; j++) {
        searchPtr = &text[i];
        while (searchPtr = strchr(searchPtr, 'a' + i)) {
          ++count;
          searchPtr++;
        }
      }
      character[i] = count;
    }
  }
  cout << endl << endl;

  for (i = 0; i <= 25; i++) {
    cout << "("
         << (char) ('A' + i)
         << " , "
         << (char) ('a' + i)
         << ") = "
         << character[i]
         << endl;
  }
  cout << endl;
  system("pause");
}

The only instantly odd thing I can see is using a char array to COUNT things.
It's not that you can't, it's just that they will be output as chars (and not numbers).

Don't PM me for help.

You need to sit down and rethink your logic.

1. Think about the problem and what it is you want to do
2. Come up with a solution to the problem
3. Write psuedocode on how you would solve the problem using paper and pencil
4. Convert your psuedocode to C
5. Run your program and see results
6. If you are still stuck, post your latest attempt, along with any error messages/warnings and output if you are getting something not expected.

Additionally, getline is delimited by the newline char in your example so your while statement doesn't really do anything for you.
As a side note, you shouldn't be using char arrays or cstring functions when you are working with C++. The C++ solution is at least 10 times easier to write.