Thread: No errors but still a problem.

So, I'm having another issue with my little text based game I am making. I've corrected all the mistakes in my coding (i get no build errors) however when I run the game I cannot access certain areas. I think I have messed something up on either player.cpp, player.h, or the "Motel" portion of suburbs.cpp because before I wrote those codes everything worked as it should. Below is a link to my files because it put them in this tread would be just a bit to much to read. Here's hoping someone will take the time to d/l them and help me because I have no clue what I've done... Also, I'm new here so if this is the wrong way to post my problem (i.e. no one in their right mind will download someone elses code) then someone let me know so i can correct it and get some help

SaveTheGinger

WARNING: My game contains strong language that is not suitable for those easily offended. If you choose to d/l to help me, be forewarned. I do not wish to offend anyone that is trying to help me.

Before checking the code, here are some tips and useful information:
- The .ncb file is not necessary to bundle along. It contains IntelliSense information all will be recreated by the IDE automatically.
- The Debug and Release folders can be omitted too since they contain the compiled code and can be re-created by compiling.
- You should upgrade to VS2010.

Problem:
- void main shall be int main.
- Do not use C-style strings. For example, char name[32] should be std::string name.
- Using upper-case names for classes is not recommended. They are reserved for macros, usually.
- This is good advice: http://sourceforge.net/apps/mediawik...arameter_names
- Do not put declarations into some global header file. Separate everything into source files and their complementing header file. For example, Suburbs.cpp and Suburbs.h, not Suburbs.cpp and Globals.h.
- Never use cin >> with a char array. This is a ticking time bomb (see buffer overrun). Use std::string with (std::cin >> or std::getline).
- Read up on references instead of using pointers all the time.
- Avoid global variables. Prefer passing them around as arguments if you must.
- bool hcomplete = false(); <-- false is not a type, hence the parenthesises there really shouldn't be there.
- Why does Apartment return anything when you always return true?
- You are missing const correctness. A topic to study, I believe.
- Don't use strcpy. It's unsafe (see buffer overruns). Instead use std::string with the normal assignment operator.

Well, you should probably start with this before expanding on your code.
And you might also tell us how to reproduce the bug, if you don't mind.

I suspect this is something I shouldn't download at work

it IS just a text based game so I wouldn't see the harm in downloading it. it only has one or two "dirty" words anyway

The problem, it the best way i can describe it, i was following a tutorial i found to make text based games. after seeing your posts, i would assume i'm using outdated code. as i followed the tutorial it asked to make a starting area for the player, an area that the player could repeatedly come back to in order to obtain new quests or go to town for supplies. I chose to call this place "the apartment". now, after a while in the tutorial, i had made the title screen "the apartment", and "the suburbs" (town). options from "the apartment" allowed you to travel to "the suburbs" and back. everything worked fine (after fixing a few errors). once i continued the tutorial, i was asked to make an inn for the town ("motel" for "the suburbs") and define the player. this is where everything went wrong. after fixing a few errors and finally getting a successful build i tried to run my game. because of something i did i can no longer travel to "the suburbs". it will allow me to open the game (see title text) and, after hitting enter, see "the apartment" text and options, i can even exit the game (using option 10) but when i type option 1 (the option for "the suburbs") it takes me to the next line down and i can input nothing further. As i said, just before i added the "motel" and defined the player, everything worked fine. I hope that helps to better define the problem.

it's probably worth noting that i don't know c++, i thought that this would teach me but i think i'm drowning.... maybe i should find that "hello world" thing everyone is talking about...

Well, you should find your problems pretty quickly with a debugger (VS has one; press F5).

For one:
while(choice != 5);
should be
while(choice != 5)

while(answer[0] !='p' || answer[0] !='l')
should be
while(answer[0] !='p' && answer[0] !='l')
(Of course, this is wrong too, since you should use std::string here.)

You also have some problem with your project configuration. Click the arrow next to Debug, choose configuration manager and inside select "Debug" instead of "Release" on your project.

Also...
bool hcomplete = false();
This is not valid C++. It's a Visual Studio extension.
It should be
bool hcomplete = false;

I'm using VS, is that a problem? I'm only using it cause that's what the guy on the tutorial is using...

i'm going through and doing the "hello world" stuff.... i guess Save The Ginger will have to wait, at least till i learn more and/or u guys help me through this hump.

Originally Posted by d20junkie

I'm using VS, is that a problem? I'm only using it cause that's what the guy on the tutorial is using...

It's not a problem. You need to learn how to use it properly. That is all.

OMG! Elysia, you are my effen hero!!! now the only problem is that when i get to the "motel", no matter what i input, it brings me straight back to the "suburbs". wis that the "std::string name" thing you were talking about? or did i just get lost again?

i took out all the ()'s and the extra ";"'s then changed the || to && like you said

std::string has nothing to do with it.
When your function ends, you return to outside the motel, and all paths simply end with going out of the function.
This is simply a logic problem.

Suburbs calls Motel.
Motel awaits input.
User inputs l or p.
Motel returns.
Suburbs loop and asks for input.

You also seem to check for 'y' and 'n' in if statements below, but your "loop" wants 'l' or 'p'.

Originally Posted by Matticus

Will this be added to the signature?

No promises on that one

oh wow... i didn't even notice... originally i had "yes" or "no" answers instead of "pay" or "leave".... i guess i forgot to change them.... everything works perfectly now!!! elysia... can we have little programmer babies together that will be so much smarter than me? (sorry if that ends up coming across offensive, i'm just stoked that it's all working now). you're my freakin programming god! if i change all the "p"'s and "l"'s to "pay" and "leave"... then the player would have to type in the full word, right?

Originally Posted by d20junkie

elysia... can we have little programmer babies together that will be so much smarter than me? (sorry if that ends up coming across offensive, i'm just stoked that it's all working now). you're my freakin programming god!

o_O
Considering my disposition towards kids, I don't think said event would occur/[be possible] in any near future!
Perhaps you'll find some (other) smart programming gal who you'll end up marrying some day