Thread: Adding a local Variable to a Vector Question

Hi,

I'm a C programmer developing a basic audio mixer in C++. The program consists of multiple audio tracks each containing multiple audio clips. I'm running into problems with the audio clips which I add to a vector class variable as follows:

Code:

void AudioTrack::addClip(const char *infilename, unsigned long startIndex) {
	
	// Add the clip to the clip vector.
	AudioClip* ac = new AudioClip(infilename, startIndex);
	ac->setClipNumber(clipNumber);
	audioClipVector.push_back(ac);
        ...

When the program starts I add a couple of tracks and clips for testing. This seems to work OK. However once the program starts running the first track's clip vector shows incorrect values. Here's an example:

Number of clips in Track 0: 2
Number of clips in Track 1: 1
Number of clips in Track 2: 1

Number of clips in Track 0: 4062199338
Number of clips in Track 1: 1
Number of clips in Track 2: 1

I wanted to check that the problem didn't lie in the way I was adding a local clip variable to the class variable vector - is that OK? Or is this the cause of the problem?

Cheers,

Chris

Originally Posted by laserlight

It is okay, but are you really unable to store AudioClip objects, rather than pointer, in the vector? If so, you could consider storing a std::tr1::shared_ptr<AudioClip> instead.

How would this make a difference?

Objects stored in STL container are already dynamically allocated. You are just adding another level of indirection

I wonder if the problem could be that I'm dynamically allocating memory and therefore need a copy constructor?

Originally Posted by laserlight

Since you are storing pointers, you can get away without a copy constructor.

Perhaps you should post more code, e.g., the code that demonstrates the problem.

Yes, I'll do that however the program is reasonably large so I'll have to work out which parts to post. I'll try and post something later today.

I've managed to figure out the problem. It wasn't related to the vectors. It was a simple programming oversight

I recently changed the program so that it could output stereo audio (originally it was mono) and in the process several data buffers had to have their sizes doubled. I missed one - ooops!

Thanks for the help.