Thread: What the heck is wrong with this scrips

Code:

#include <iostream>
#include <cmath>
#include <iomanip>

using namespace std;

int main()
{
    int N1;
    char act;
    int N2;


    cout << "\t\t|~-~-~-~-~-~-~|\n"
            "\t\t| Calculator  |\n"
            "\t\t|~-~-~-~-~-~-~|\n";
    cout << "\n"
            "+=Add\t\t\t S=sqrt\n"
            "-=Subtract\t\t ^=Exponent\n"
            "*=multiply\t\t COMEING\n"
            "/=divide\t\t Q=Quit\n\n";
    while(act != 'Q')
        {
            cin>>N1>>act>>N2;
            if (act='+')
                cout<<N1+N2;
            if (act='-')
                cout<<N1-N2;
            if (act='*')
                cout<<N1*N2;
            if (act='/')
                cout<<N1/N2;
            if (act='s')
                cout<<sqrt(N1);
            if (act='^')
                cout<<pow(N1, N2);
        }
    cin.get();
}

I want it to loop there so that you can continue entering different equations in without re-opening. Without a loop u can only enter 1 eqaution each time u open the program.

Well I am not an expert like I said but it would be nice if you mentioned what is going wrong. Does it not compile are there any run time problems?

OH, yeah srry. Well when I try to quit it gets a glitchy and puts tons of numbers(infinate 0's and 1's sometimes and +[some random large number] over and over again). I just made the script go on forever to make it work. To quit u just push button at top. So my next problem is it always things I want to add the numbers together. If I put 76*13 it says 89, or 5-2 it says 7...

Well like I said I am a beginner myself and I might be overlooking the same thing as you are but what I think you could try the characters in a 'char'. I do not know if they are reserved by C++ or not. You might want to try it using the ASCII value of the character instead.

Did you also tried it with initializing the variables like I said. It could be that if you press 'Q' right away that certain values are taken from what used to be at that memory location.

Hope some one more experienced can look at this if those two do not help because I would not knw what could be wrong otherwise.....

Dont really get what ur saying with the frist one mate... Yeah I tried initializing the variable as a specific number before the loop... Didn't work... Seems like a simple script but its being very difficult.

A char can hold a character but also the ASCII value of the character.

ASCII Code - The extended ASCII table

= and == are not the same thing ! Your If conditions are broken.

So you want me to say: if (act='00101011') for + because the table says
43 053 2B 00101011 + + Plus

a simple

Code:

if(act=='+')

would be enough!

I tried using the 0's and ones as well as the & # 4 5 ;(there are spaces so the computer doesn't post it as a +)

Stupid that I missed that.

Look at what 'manasij7479' said. You are not comparing in your if statements you are assigning the value.

PS. When using the ASCII table to initialize a char you use the decimal number of the ASCII character.

Ugh I needed to do if (x==y) instead of if (x=y)... Thats what was wrong... It all works now! Well besides the quiting part, but theres a button for that so...

quitting should work fine ..Are you putting in 'Q' or 'q' ?