Thread: Reading a file not working

This is probably pretty simple... This is my first year of dedicated learing C++ though, so give me some slack please. :P Well, i'm basically making a checkbooking program to create an example of using <fstream> to get better at it and such. I have most of my program working, but the error I have is when I try to read the file. (I'm storing information to a file to allow it to save for the next time I run the program.) Ive narrowed the error to my reading file function... Here's the code:

Code:

void display_transactions()
{
	ifstream fin;
	string book;

	fin.open("money.text");		// Opens record file
	do{				// Loop to be sure to read the WHOLE file
	     fin >> book;  // Saves the line
	     cout << endl << book << endl;  // Prints the line
	}while(fin.eof() == FALSE);

	fin.close();	// Closes file
}

I would appreciate any ideas on how to fix this... Thanks!

What's the error? You shouldn't use .eof(), you should just do

Code:

while (fin >> book)
    cout << endl << book << endl;

Well, when it gets to that portion of the program, it runs an infinite loop of blank lines... The .eof() is supposed to stop the loop when it reaches the end of the file from what I understand (given the parameters of the loop)...

Well, I tried your code and it didn't work. Didn't have an infinite loop though.

Fun fact: an invalid file stream will not have .eof set. I would be surprised if your filename extension was actually ".text" instead of ".txt".

Oh. That was quite a typo. Thank you very much.

And yes that fixed it. It works perfectly the way I want it to now. Thank you!

Hooray for working!

Two other things:
1) Your original code would have printed the last item in the file twice (.eof() is not set until after a read fails).

2) "false" exists in the C++ language as a keyword, so there's no reason to define your own FALSE macro.