Thread: Newbie needs advice please..

Hi,

I have just started learning C++ and while messing around with calling and returning I have unexpected results.

As far as I understood it I should be able to use the values returned from other functions outside of 'main' and use them as I would any 'int' value as shown below.

But it loops through the program twice for some reason and then doesn't display the user input information as I thought it should.

Any pointers would be appreciated.

Code:

#include "stdafx.h"
#include <stdlib.h>
#include <iostream>

using namespace std;

int age() 
{
	int ageyouare;
	cout << "Please enter your age: ";
	cin >> ageyouare;
	cin.ignore();
	system("cls");
	return ageyouare;
}


int yearofbirth() 
{
	int year;
	cout << "Please enter the year you were born: ";
	cin >> year;
	cin.ignore();
	system("cls");
	return year;
}

int main()
{
	int y;
	int a;
	yearofbirth();
	age();
	y = yearofbirth();
	a = age();
	cout << "You are: " << a << "\n";
	cout << "And you were born in the year: " << y << "\n";
		
	char f;
	cin >> f;
	return 0;
}

It's not looping through the program twice. You are calling yearofbirth and age twice in main, but in the first call to each function you are not assigning the return value to anything. Delete those two useless lines and the program will work as you were expecting.

Thanks alot!

I thought I had to seperately run the functions and THEN assign the values from those to y and a.

Which I now see was not needed!


cheers

Thanks for the replies that makes it much clearer now.

I can see this becoming an addiciton.