Style issue?

[morbidslug]

Rogster brought this up in my other thread (by accident as he doesn't know why I do this):

Is it ok to put all your #includes in your header files?

When I have multiple objects referencing each other I put all the #include's in the 'top' one (ie/ the one which must be #include'd by the most other obj's) working 'down' through the header files and only #include'ing somethign if it is neccessary at that 'level' of my header-include heirachy.

Is this bad as far as performance goes? What is the 'best' way to #include things?

I know there's no code here but maybe there is a better way (I don't ever #pragma, as I like to keep stuff under my control) to maintain a 'tidy' style out there.

Morb

[morbidslug]

obviously you must #include the header files which contain the relavent #includes, owch....

[laserlight]

If I only need a forward declaration of a class in a header, I would rather write out that forward declaration in my header than include the header that contains the definition of that class.

Is this bad as far as performance goes? What is the 'best' way to #include things?

The performance thing is only a compile-time issue: when a header file is changed, all source files that include that header should be re-compiled. So, if you have a universal header file that includes pretty much all other headers, then you would typically end up re-compiling all your source files if any header file is changed, when it may be the case that you just need to re-compile one or two source files.

[morbidslug]

Beautiful, cheers