Thread: help

i have a program here and it wont work i think there is a problem in the array

Code:

#include<stdio.h>
#include<conio.h>
#include<iostream>
#include<string.h>
using namespace std;
class Dog
{
      int age,weight;
      char color[11];
      public:
             
             void setValues(int, int, char[]);
             int getAge(){return(age);}
             int getWeight(){return(weight);}  
            char getcolor(){return(color[]);}  // problem here am i returning this array right
            void bark(){cout<< "woof!"<<endl;}    
};
void Dog::setValues(int age, int weight, char color[])
{
     this -> age = age;
     this -> weight = weight;
     strcpy(this -> color,color);
};
main()
{
      Dog fido, pooch;
      fido.setValues(3,15,"brown");
      
      pooch.setValues(4,18,"gray");
     cout<<"pooch is a" << pooch.getAge()<<endl;
     cout<<"year old " << pooch.getcolor()<<endl;
     cout<<"dog who weighs" << pooch.getWeight()<<endl;
     cout<<"pounds";
      
      pooch.bark();
      getch();
}

Help I failed my driving test can you tell me how to pass I don't know why I can't pass

Originally Posted by ಠ_ಠ

Originally Posted by whiteflags

Help I failed my driving test can you tell me how to pass I don't know why I can't pass

You ran over your driving instructors dog, run the test again and you should pass, he doesn't have a dog any more

vBulletin needs a "like" button.

To the OP: Your code is wide open to buffer overflows. Consider using strncpy instead of strcpy in your Dog::setValues() method.

Originally Posted by PehJota

vBulletin needs a "like" button.

To the OP: Your code is wide open to buffer overflows. Consider using strncpy instead of strcpy in your Dog::setValues() method.

Or, rather, C++ strings!

And mouse: After so many posts I'd expect you'd know at least how to make up a proper title...