Thread: object creation

Yes, you could use an array. Why don't you give it a try as it apparently only requires a small change to your program?

Originally Posted by rafay_07

i have tried but its not working
i think i dont know how to declare that because i m trying like

Yeah. The first problem is that you did not declare size to be const. The next problem is that you started looping from 1 instead of 0, thus you missed the first element of the array and accessed one past the end of the array, which is wrong. Here's what you might do:

Code:

#include <iostream>

using namespace std;

class student {
public:
    void get_info()
    {
        cout << "enter name of student: ";
        cin.getline(name, 50);
        cout << "enter blood group of student: ";
        cin.getline(blood_group, 15);
    }

    void show_info()
    {
        cout << "name is: " << name << endl;
        cout << "blood group is: " << blood_group << endl;
        cout << "roll number is: " << ++roll_num << endl;
    }
private:
	char name[50];
	char blood_group[15];

    static int roll_num;
};

int student::roll_num = 0;

int main()
{
    const int size = 4;
    student students[size];

    for (int i = 0; i < size; ++i)
    {
        students[i].get_info();
    }

    for (int i = 0; i < size; ++i)
    {
        students[i].show_info();
    }
}

Notice that in addition to the changes I mentioned, I also declared roll_num as a static member variable, in addition to defining it.

That said, I would not design the class in this way: roll_number is not really something that has to do with students, and then you should be providing ways to access the elements of the student object in useful and flexible ways, not just provide two member functions that do things that are so specific.

Originally Posted by rafay_07

1. if i declare some variable in public access specifier then this variable is a data member or not?

Yes, it is still a data member.

Originally Posted by rafay_07

2. i have only used roll number as a static data member what other features of class student can be declared as static data member?

As I stated earlier, I don't think roll number should be a static member variable. It should be a counter used in the code that uses the student objects, not part of the student class.

Originally Posted by rafay_07

3. u said that "then you should be providing ways to access the elements of the student object in useful and flexible ways, not just provide two member functions that do things that are so specific."
respectfully i did not get u actually

For example, I might write the class like this:

Code:

class Student {
public:
    Student() {}

    Student(const std::string& name_, const std::string& blood_group_)
        : name(name_), blood_group(blood_group_) {}

    std::string getName() const
    {
        return name;
    }

    std::string getBloodGroup() const
    {
        return blood_group;
    }

    void setName(const std::string& name_)
    {
        name = name_;
    }

    void setBloodGroup(const std::string& blood_group_)
    {
        blood_group = blood_group_;
    }
private:
    std::string name;
    std::string blood_group;
};

In the above code, the Student class with the getters and setters is not much better than:

Code:

struct Student
{
    std::string name;
    std::string blood_group;
};

But the difference between your code is that there is a more general interface, i.e., to access the class members through the getters and setters. You could be a little smarter, for example, and make setBloodGroup perform some input checking.